Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix streaming node lint error #34790

Closed
wants to merge 1 commit into from
Closed

fix: fix streaming node lint error #34790

wants to merge 1 commit into from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jul 18, 2024

issue: #33285

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from czs007 and sunby July 18, 2024 07:21
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 18, 2024
@chyezh
Copy link
Contributor Author

chyezh commented Jul 18, 2024

rerun ut

2 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Jul 18, 2024

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Jul 19, 2024

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Jul 19, 2024

already merged with #34653

@chyezh chyezh closed this Jul 19, 2024
@chyezh chyezh deleted the fix_go_lint_fixup branch July 19, 2024 09:50
@weiliu1031 weiliu1031 mentioned this pull request Nov 12, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Nov 12, 2024
@weiliu1031 @xiaofan-luan
enhance: optimize describe collection and index (#37490) (#37605)
074f8ee 
fix #37489
pr: #34790
combine multiple describe collection and list index into one call

Signed-off-by: xiaofanluan <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: Xiaofan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@sunby sunby Awaiting requested review from sunby

Assignees
No one assigned
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chyezh @sre-ci-robot