Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] pick default root password and log level pr #34777

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (d74a5bd) to head (d85ee69).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34777      +/-   ##
==========================================
- Coverage   81.15%   81.13%   -0.03%     
==========================================
  Files         786      786              
  Lines      112773   112871      +98     
==========================================
+ Hits        91525    91581      +56     
- Misses      16855    16889      +34     
- Partials     4393     4401       +8     
Files Coverage Δ
internal/rootcoord/root_coord.go 91.93% <100.00%> (ø)
pkg/util/constant.go 93.33% <ø> (ø)
pkg/util/paramtable/component_param.go 98.29% <100.00%> (+0.01%) ⬆️

... and 32 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0e22650 into milvus-io:2.4 Jul 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants