Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [skip e2e] effective way to use cache #34774

Merged
merged 1 commit into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions .github/actions/cache-restore/action.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: 'Milvus Cache'
description: ''
inputs:
os:
description: 'OS name'
required: true
default: 'ubuntu20.04'
kind:
description: 'Cache kind'
required: false
default: 'all'
runs:
using: "composite"
steps:
- name: Generate CCache Hash
env:
CORE_HASH: ${{ hashFiles( 'internal/core/**/*.cpp', 'internal/core/**/*.cc', 'internal/core/**/*.c', 'internal/core/**/*.h', 'internal/core/**/*.hpp', 'internal/core/**/CMakeLists.txt') }}
run: |
echo "corehash=${CORE_HASH}" >> $GITHUB_ENV
echo "Set CCache hash to ${CORE_HASH}"
shell: bash
- name: Cache CCache Volumes
if: ${{ inputs.kind == 'all' || inputs.kind == 'cpp' }}
uses: actions/cache/restore@v4
with:
path: .docker/amd64-${{ inputs.os }}-ccache
key: ${{ inputs.os }}-ccache-${{ env.corehash }}
restore-keys: ${{ inputs.os }}-ccache-
- name: Cache Conan Packages
if: ${{ inputs.kind == 'all' || inputs.kind == 'cpp' }}
uses: actions/cache/restore@v4
with:
path: .docker/amd64-${{ inputs.os }}-conan
key: ${{ inputs.os }}-conan-${{ hashFiles('internal/core/conanfile.*') }}
restore-keys: ${{ inputs.os }}-conan-
- name: Cache Third Party
if: ${{ inputs.kind == 'all' || inputs.kind == 'thirdparty' }}
uses: actions/cache/restore@v4
with:
path: .docker/thirdparty
key: ${{ inputs.os }}-thirdparty-${{ hashFiles('internal/core/thirdparty/**') }}
restore-keys: ${{ inputs.os }}-thirdparty-
- name: Cache Go Mod Volumes
if: ${{ inputs.kind == 'all' || inputs.kind == 'go' }}
uses: actions/cache/restore@v4
with:
path: .docker/amd64-${{ inputs.os }}-go-mod
key: ${{ inputs.os }}-go-mod-${{ hashFiles('go.sum, */go.sum') }}
restore-keys: ${{ inputs.os }}-go-mod-
49 changes: 49 additions & 0 deletions .github/actions/cache-save/action.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: 'Milvus Cache'
description: ''
inputs:
os:
description: 'OS name'
required: true
default: 'ubuntu20.04'
kind:
description: 'Cache kind'
required: false
default: 'all'
runs:
using: "composite"
steps:
- name: Generate CCache Hash
env:
CORE_HASH: ${{ hashFiles( 'internal/core/**/*.cpp', 'internal/core/**/*.cc', 'internal/core/**/*.c', 'internal/core/**/*.h', 'internal/core/**/*.hpp', 'internal/core/**/CMakeLists.txt') }}
run: |
echo "corehash=${CORE_HASH}" >> $GITHUB_ENV
echo "Set CCache hash to ${CORE_HASH}"
shell: bash
- name: Cache CCache Volumes
if: ${{ inputs.kind == 'all' || inputs.kind == 'cpp' }}
uses: actions/cache/save@v4
with:
path: .docker/amd64-${{ inputs.os }}-ccache
key: ${{ inputs.os }}-ccache-${{ env.corehash }}
restore-keys: ${{ inputs.os }}-ccache-
- name: Cache Conan Packages
if: ${{ inputs.kind == 'all' || inputs.kind == 'cpp' }}
uses: actions/cache/save@v4
with:
path: .docker/amd64-${{ inputs.os }}-conan
key: ${{ inputs.os }}-conan-${{ hashFiles('internal/core/conanfile.*') }}
restore-keys: ${{ inputs.os }}-conan-
- name: Cache Third Party
if: ${{ inputs.kind == 'all' || inputs.kind == 'thirdparty' }}
uses: actions/cache/save@v4
with:
path: .docker/thirdparty
key: ${{ inputs.os }}-thirdparty-${{ hashFiles('internal/core/thirdparty/**') }}
restore-keys: ${{ inputs.os }}-thirdparty-
- name: Cache Go Mod Volumes
if: ${{ inputs.kind == 'all' || inputs.kind == 'go' }}
uses: actions/cache/save@v4
with:
path: .docker/amd64-${{ inputs.os }}-go-mod
key: ${{ inputs.os }}-go-mod-${{ hashFiles('go.sum, */go.sum') }}
restore-keys: ${{ inputs.os }}-go-mod-
35 changes: 31 additions & 4 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
echo "useasan=ON" >> $GITHUB_ENV
echo "Setup USE_ASAN to true since cpp file(s) changed"
- name: Download Caches
uses: ./.github/actions/cache
uses: ./.github/actions/cache-restore
with:
os: 'ubuntu22.04'
kind: 'cpp'
Expand All @@ -104,6 +104,13 @@ jobs:
with:
name: code
path: code.zip
- name: Save Caches
uses: ./.github/actions/cache-save
if: github.event_name != 'pull_request'
with:
os: 'ubuntu22.04'
kind: 'cpp'

UT-Cpp:
name: UT for Cpp
needs: Build
Expand All @@ -127,7 +134,7 @@ jobs:
unzip code.zip
rm code.zip
- name: Download Caches
uses: ./.github/actions/cache
uses: ./.github/actions/cache-restore
with:
os: 'ubuntu22.04'
kind: 'cpp'
Expand All @@ -150,6 +157,12 @@ jobs:
./lcov_output.info
*.info
*.out
- name: Save Caches
uses: ./.github/actions/cache-save
if: github.event_name != 'pull_request'
with:
os: 'ubuntu22.04'
kind: 'cpp'
UT-Go:
name: UT for Go
needs: Build
Expand All @@ -173,7 +186,7 @@ jobs:
unzip code.zip
rm code.zip
- name: Download Caches
uses: ./.github/actions/cache
uses: ./.github/actions/cache-restore
with:
os: 'ubuntu22.04'
kind: 'go'
Expand All @@ -195,6 +208,13 @@ jobs:
./lcov_output.info
*.info
*.out
- name: Save Caches
uses: ./.github/actions/cache-save
if: github.event_name != 'pull_request'
with:
os: 'ubuntu22.04'
kind: 'go'

integration-test:
name: Integration Test
needs: Build
Expand All @@ -218,7 +238,7 @@ jobs:
unzip code.zip
rm code.zip
- name: Download Caches
uses: ./.github/actions/cache
uses: ./.github/actions/cache-restore
with:
os: 'ubuntu22.04'
kind: 'go'
Expand All @@ -239,6 +259,13 @@ jobs:
./it_coverage.txt
*.info
*.out
- name: Save Caches
uses: ./.github/actions/cache-save
if: github.event_name != 'pull_request'
with:
os: 'ubuntu22.04'
kind: 'go'

codecov:
name: Upload Code Coverage
needs: [UT-Cpp, UT-Go, integration-test]
Expand Down
Loading