enhance: mark duplicated pk as deleted #34586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34586 +/- ##
===========================================
+ Coverage 69.81% 84.48% +14.66%
===========================================
Files 1147 876 -271
Lines 140271 116052 -24219
===========================================
+ Hits 97927 98043 +116
+ Misses 38015 13669 -24346
- Partials 4329 4340 +11
|
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 12, 2024
pr: #34586 Signed-off-by: luzhang <[email protected]> Co-authored-by: luzhang <[email protected]>
|
@zhagnlu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
rerun ut |
1 similar comment
|
rerun ut |
|
@zhagnlu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@zhagnlu E2e jenkins job failed, comment |
Signed-off-by: luzhang <[email protected]>
|
@zhagnlu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, zhagnlu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jul 16, 2024
zhagnlu
pushed a commit
to zhagnlu/milvus
that referenced
this pull request
Jul 30, 2024
This reverts commit 86322e0. Revert "enhance: mark duplicated pk as deleted (milvus-io#34586)" This reverts commit 804dd54.
zhagnlu
pushed a commit
to zhagnlu/milvus
that referenced
this pull request
Jul 30, 2024
Revert "fix: fix query count(*) concurrently (milvus-io#35007)" This reverts commit 86322e0. Revert "enhance: mark duplicated pk as deleted (milvus-io#34586)" This reverts commit 804dd54.
zhagnlu
pushed a commit
to zhagnlu/milvus
that referenced
this pull request
Jul 30, 2024
Revert "fix: fix query count(*) concurrently (milvus-io#35007)" Revert "enhance: mark duplicated pk as deleted (milvus-io#34586)"
zhagnlu
pushed a commit
to zhagnlu/milvus
that referenced
this pull request
Jul 30, 2024
Revert "fix: fix query count(*) concurrently (milvus-io#35007)" Revert "enhance: mark duplicated pk as deleted (milvus-io#34586)" Signed-off-by: luzhang <[email protected]>
zhagnlu
pushed a commit
to zhagnlu/milvus
that referenced
this pull request
Jul 30, 2024
Revert "fix: fix query count(*) concurrently (milvus-io#35007)" Revert "enhance: mark duplicated pk as deleted (milvus-io#34586)" Signed-off-by: luzhang <[email protected]>
zhagnlu
pushed a commit
to zhagnlu/milvus
that referenced
this pull request
Aug 1, 2024
Revert "fix: fix query count(*) concurrently (milvus-io#35007)" Revert "enhance: mark duplicated pk as deleted (milvus-io#34586)" Signed-off-by: luzhang <[email protected]>
zhagnlu
pushed a commit
to zhagnlu/milvus
that referenced
this pull request
Aug 1, 2024
Revert "fix: fix query count(*) concurrently (milvus-io#35007)" Revert "enhance: mark duplicated pk as deleted (milvus-io#34586)" Signed-off-by: luzhang <[email protected]>
zhagnlu
pushed a commit
to zhagnlu/milvus
that referenced
this pull request
Aug 1, 2024
Revert "fix: fix query count(*) concurrently (milvus-io#35007)" Revert "enhance: mark duplicated pk as deleted (milvus-io#34586)" Signed-off-by: luzhang <[email protected]>
zhagnlu
pushed a commit
to zhagnlu/milvus
that referenced
this pull request
Aug 2, 2024
Revert "fix: fix query count(*) concurrently (milvus-io#35007)" Revert "enhance: mark duplicated pk as deleted (milvus-io#34586)" Signed-off-by: luzhang <[email protected]>
zhagnlu
pushed a commit
to zhagnlu/milvus
that referenced
this pull request
Aug 2, 2024
Revert "fix: fix query count(*) concurrently (milvus-io#35007)" Revert "enhance: mark duplicated pk as deleted (milvus-io#34586)" Signed-off-by: luzhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #34247