-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: remove CheckVecIndexWithDataTypeExist function in pkg and remove some cgo call #34102
Conversation
@cqy123456 ut workflow job failed, comment |
rerun ut |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34102 +/- ##
===========================================
+ Coverage 69.80% 84.63% +14.83%
===========================================
Files 1077 810 -267
Lines 137148 113139 -24009
===========================================
+ Hits 95731 95756 +25
+ Misses 37201 13167 -24034
Partials 4216 4216
|
Signed-off-by: cqy123456 <[email protected]>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cqy123456, jaime0815 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…in pkg (#34104) issue: #22837 related pr: #34102 Signed-off-by: cqy123456 <[email protected]>
…move some cgo call (milvus-io#34102) issue: milvus-io#22837 related pr: milvus-io#34104 Signed-off-by: cqy123456 <[email protected]>
issue: #22837
related pr: #34104