Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to enable/disable vector field clustering key #34097

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Jun 24, 2024

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 24, 2024
Copy link
Contributor

mergify bot commented Jun 24, 2024

@wayblink

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Jun 24, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@wayblink wayblink changed the title Add a option to enable/disable vector field clustering key Add an option to enable/disable vector field clustering key Jun 24, 2024
Copy link
Contributor

mergify bot commented Jun 24, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added the ci-passed label Jun 24, 2024
@mergify mergify bot removed the ci-passed label Jun 25, 2024
@wayblink
Copy link
Contributor Author

rerun ut

@czs007
Copy link
Collaborator

czs007 commented Jun 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (fb870d2) to head (6eaf4d1).
Report is 28 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34097      +/-   ##
==========================================
+ Coverage   81.00%   81.02%   +0.01%     
==========================================
  Files        1067     1077      +10     
  Lines      136726   137172     +446     
==========================================
+ Hits       110759   111139     +380     
- Misses      21754    21815      +61     
- Partials     4213     4218       +5     
Files Coverage Δ
internal/proxy/task.go 87.71% <100.00%> (+0.18%) ⬆️
pkg/util/merr/errors.go 86.95% <ø> (ø)
pkg/util/merr/utils.go 83.15% <100.00%> (+0.15%) ⬆️
pkg/util/paramtable/component_param.go 98.48% <100.00%> (+<0.01%) ⬆️
internal/util/clustering/clustering.go 62.00% <16.66%> (-4.67%) ⬇️

... and 185 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 25, 2024
@sre-ci-robot sre-ci-robot merged commit f9a0f7b into milvus-io:master Jun 25, 2024
12 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
czs007 pushed a commit that referenced this pull request Jul 3, 2024
This PR cherry-picks the following commits:

- fix: sync partitiion stats blocking balance task #33742
- fix: Fix meta prefix overlap bug #33830
- fix: Small fixs of major compaction #33929 
- fix: Fix memory buffer error & some renaming #33850
- fix: sync part stats task cannot be finished #34027 
- Add an option to enable/disable vector field clustering key #34097
- fix: fix error ignore in compactor #34169
- fix:load major compaction partial result #34052
- Use new stream segment reader in clustering compaction #34232

issue: #30633
pr: #33742 #33830 #33929 #33850 #34027 #34097 #34169 #34052 #34232

---------

Signed-off-by: MrPresent-Han <[email protected]>
Signed-off-by: wayblink <[email protected]>
Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: Chun Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/invalid-pr-format lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants