Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add metrics for segment prune latnecy(#30376) #34094

Conversation

MrPresent-Han
Copy link
Contributor

related: #30376

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 24, 2024
Copy link
Contributor

mergify bot commented Jun 24, 2024

@MrPresent-Han ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (ac28402) to head (dedd563).
Report is 56 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #34094       +/-   ##
===========================================
+ Coverage   69.80%   80.70%   +10.90%     
===========================================
  Files        1077     1077               
  Lines      137148   137156        +8     
===========================================
+ Hits        95731   110698    +14967     
+ Misses      37201    22239    -14962     
- Partials     4216     4219        +3     
Files Coverage Δ
internal/querynodev2/delegator/segment_pruner.go 69.81% <100.00%> (+1.39%) ⬆️
pkg/metrics/querynode_metrics.go 100.00% <100.00%> (ø)

... and 263 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 24, 2024
@MrPresent-Han MrPresent-Han force-pushed the add-segment-prune-latency-metrics-master branch from 0d650ae to dedd563 Compare June 25, 2024 06:07
@mergify mergify bot removed the ci-passed label Jun 25, 2024
@MrPresent-Han
Copy link
Contributor Author

rerun ut

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 34bec2e into milvus-io:master Jul 3, 2024
12 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 4, 2024
related: #30376
pr: #34094

Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants