Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do compressBinlog to fix logID 0 (#34060) #34062

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

bigsheeper
Copy link
Contributor

Do compressBinlog to ensure that reloadFromKV will fill binlogs' logID after datacoord restarts.

issue: #34059

pr: #34060

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 21, 2024
Signed-off-by: bigsheeper <[email protected]>
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jun 22, 2024
@sre-ci-robot sre-ci-robot merged commit 2fda43e into milvus-io:2.4 Jun 22, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants