Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support inverted index for array (#33452) #34053

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

longjiquan
Copy link
Contributor

pr: #33184
pr: #33452
pr: #33633
issue: #27704
Co-authored-by: xiaocai2333 [email protected]

Copy link
Contributor

mergify bot commented Jun 21, 2024

@longjiquan Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/feature Issues related to feature request from users labels Jun 21, 2024
@mergify mergify bot added dco-passed DCO check passed. ci-passed and removed needs-dco DCO is missing in this pull request. labels Jun 21, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 60.19576% with 244 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (fbc8fb3) to head (af75359).
Report is 13 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34053      +/-   ##
==========================================
- Coverage   82.30%   82.14%   -0.17%     
==========================================
  Files        1015     1005      -10     
  Lines      129488   130046     +558     
==========================================
+ Hits       106580   106821     +241     
- Misses      18929    19244     +315     
- Partials     3979     3981       +2     
Files Coverage Δ
internal/core/src/common/Schema.h 100.00% <100.00%> (ø)
internal/core/src/exec/expression/Expr.h 83.21% <100.00%> (+0.39%) ⬆️
...ternal/core/src/exec/expression/JsonContainsExpr.h 100.00% <ø> (ø)
internal/core/src/exec/expression/UnaryExpr.h 82.08% <ø> (+3.30%) ⬆️
internal/core/src/index/IndexFactory.h 100.00% <ø> (ø)
internal/core/src/index/InvertedIndexTantivy.h 47.36% <100.00%> (ø)
internal/core/src/indexbuilder/IndexFactory.h 43.47% <ø> (-2.53%) ⬇️
internal/core/src/storage/Types.h 22.64% <ø> (-1.00%) ⬇️
internal/indexnode/indexnode_service.go 84.01% <100.00%> (+0.14%) ⬆️
internal/indexnode/util.go 40.00% <100.00%> (+40.00%) ⬆️
... and 14 more

... and 212 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jun 24, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added the manual-pass manually set pass before ci-passed labeled label Jun 24, 2024
@sre-ci-robot sre-ci-robot merged commit 22e6807 into milvus-io:2.4 Jun 24, 2024
14 of 15 checks passed
@longjiquan longjiquan deleted the cp-array-index branch June 24, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/internal-api area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants