Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add nilness linter and fix some small issues #34049

Merged

Conversation

congqixia
Copy link
Contributor

Add nilness for govet linter and fixed some detected issues

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Jun 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 21, 2024
Add `nilness` for govet linter and fixed some detected issues

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the enhance/fix_some_lint_issue branch from 9db0e3b to 625290d Compare June 22, 2024 14:18
@mergify mergify bot added the ci-passed label Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.01%. Comparing base (fb870d2) to head (625290d).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34049      +/-   ##
==========================================
+ Coverage   81.00%   81.01%   +0.01%     
==========================================
  Files        1067     1067              
  Lines      136726   136712      -14     
==========================================
+ Hits       110759   110764       +5     
+ Misses      21754    21738      -16     
+ Partials     4213     4210       -3     
Files Coverage Δ
internal/indexnode/task_analyze.go 14.78% <ø> (+1.07%) ⬆️
internal/proxy/simple_rate_limiter.go 83.50% <100.00%> (ø)
internal/storage/azure_object_storage.go 89.14% <ø> (-0.41%) ⬇️

... and 25 files with indirect coverage changes

@XuanYang-cn
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit fd922d9 into milvus-io:master Jun 24, 2024
15 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
Add `nilness` for govet linter and fixed some detected issues

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants