enhance:[Cherry-Pick] Refine varchar length exceeds max length error message (#31521) #34034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us-io#31521) Signed-off-by: aoiasd <[email protected]>
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #34034 +/- ##
==========================================
+ Coverage 83.00% 83.07% +0.07%
==========================================
Files 851 851
Lines 107495 106984 -511
==========================================
- Hits 89226 88879 -347
+ Misses 14966 14791 -175
- Partials 3303 3314 +11
|
tedxu
reviewed
Jun 24, 2024
| } | ||
| } | ||
| } | ||
| return v.checkArrayElement(data, fieldSchema) | ||
| } | ||
|
|
||
| func verifyLengthPerRow[E interface{ ~string | ~[]byte }](strArr []E, maxLength int64) error { | ||
| func verifyLengthPerRow[E interface{ ~string | ~[]byte }](strArr []E, maxLength int64) (int, bool) { |
There was a problem hiding this comment.
Any particular reason to change the method signature here?
There was a problem hiding this comment.
IMHO, to return the error index
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aoiasd, congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr: #31521