Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync part stats task cannot be finished(#30376) #34027

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Jun 20, 2024

related: #30376
also: refine log output for query_coord task by rephrasing action string

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 20, 2024
Copy link
Contributor

mergify bot commented Jun 20, 2024

@MrPresent-Han ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (2f6f964) to head (774d836).
Report is 41 commits behind head on master.

Current head 774d836 differs from pull request most recent head 957b687

Please upload reports for the commit 957b687 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34027      +/-   ##
==========================================
+ Coverage   80.92%   80.96%   +0.04%     
==========================================
  Files        1062     1064       +2     
  Lines      136133   136560     +427     
==========================================
+ Hits       110168   110570     +402     
+ Misses      21788    21782       -6     
- Partials     4177     4208      +31     
Files Coverage Δ
internal/querycoordv2/task/task.go 97.70% <100.00%> (-0.07%) ⬇️
internal/querynodev2/delegator/delegator.go 86.87% <100.00%> (+0.02%) ⬆️
internal/storage/partition_stats.go 81.39% <100.00%> (+0.90%) ⬆️
pkg/common/map.go 100.00% <100.00%> (ø)
internal/querynodev2/delegator/segment_pruner.go 68.42% <50.00%> (+0.20%) ⬆️
internal/querycoordv2/task/action.go 90.17% <76.92%> (-2.68%) ⬇️

... and 53 files with indirect coverage changes

also: refine log output for query_coord task by rephrasing action string

Signed-off-by: MrPresent-Han <[email protected]>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 24, 2024
@sre-ci-robot sre-ci-robot merged commit ca7ef26 into milvus-io:master Jun 24, 2024
12 of 13 checks passed
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Jun 26, 2024
@czs007
Copy link
Collaborator

czs007 commented Jun 26, 2024

@MrPresent-Han please pick after major compaction been picked

yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
…-io#34027)

related: milvus-io#30376
also: refine log output for query_coord task by rephrasing action string

Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
wayblink pushed a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
…-io#34027)

related: milvus-io#30376
also: refine log output for query_coord task by rephrasing action string

Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
wayblink pushed a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
…-io#34027)

related: milvus-io#30376
also: refine log output for query_coord task by rephrasing action string

Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
…-io#34027)

related: milvus-io#30376
also: refine log output for query_coord task by rephrasing action string

Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
Co-authored-by: wayblink <[email protected]>
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
…-io#34027)

related: milvus-io#30376
also: refine log output for query_coord task by rephrasing action string

Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
Co-authored-by: wayblink <[email protected]>
Signed-off-by: wayblink <[email protected]>
@czs007 czs007 removed the PR | need cherry-pick need cherry pick to other branches label Jul 2, 2024
czs007 pushed a commit that referenced this pull request Jul 3, 2024
This PR cherry-picks the following commits:

- fix: sync partitiion stats blocking balance task #33742
- fix: Fix meta prefix overlap bug #33830
- fix: Small fixs of major compaction #33929 
- fix: Fix memory buffer error & some renaming #33850
- fix: sync part stats task cannot be finished #34027 
- Add an option to enable/disable vector field clustering key #34097
- fix: fix error ignore in compactor #34169
- fix:load major compaction partial result #34052
- Use new stream segment reader in clustering compaction #34232

issue: #30633
pr: #33742 #33830 #33929 #33850 #34027 #34097 #34169 #34052 #34232

---------

Signed-off-by: MrPresent-Han <[email protected]>
Signed-off-by: wayblink <[email protected]>
Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: Chun Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants