Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: make subfunctions of datanode component modular #33992

Merged
merged 1 commit into from
Jul 1, 2024
Merged

enhance: make subfunctions of datanode component modular #33992

merged 1 commit into from
Jul 1, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Jun 19, 2024 •
edited
Loading

issue: #33994

also remove deprecated channel manager based on the etcd implementation

@sre-ci-robot sre-ci-robot added area/compilation area/dependency Pull requests that update a dependency file area/test sig/testing test/integration integration test labels Jun 19, 2024
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jun 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement do-not-merge/missing-related-issue labels Jun 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 19, 2024

@jaime0815 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@jaime0815 jaime0815 force-pushed the refactor-dn-module branch from a7986b9 to e0fa656 Compare June 19, 2024 09:51
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 19, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 19, 2024

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@jaime0815 jaime0815 force-pushed the refactor-dn-module branch from e0fa656 to 6c5b592 Compare June 19, 2024 13:14
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 19, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor

/lgtm

@jaime0815 jaime0815 force-pushed the refactor-dn-module branch from 6c5b592 to d1cdabe Compare June 20, 2024 03:15
@sre-ci-robot sre-ci-robot removed the lgtm label Jun 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 20, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.27941% with 21 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (96dcee5) to head (408434e).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33992      +/-   ##
==========================================
- Coverage   80.84%   80.58%   -0.27%     
==========================================
  Files        1085     1083       -2     
  Lines      137510   137158     -352     
==========================================
- Hits       111171   110522     -649     
- Misses      22114    22443     +329     
+ Partials     4225     4193      -32
Files Coverage Δ
internal/datacoord/channel.go 86.20% <100.00%> (+4.09%) ⬆️
internal/datacoord/channel_store.go 47.01% <100.00%> (-31.43%) ⬇️
internal/datanode/channel/channel_manager.go 94.38% <100.00%> (ø)
internal/datanode/compaction/l0_compactor.go 92.27% <100.00%> (ø)
internal/datanode/compaction/load_stats.go 48.31% <ø> (ø)
internal/datanode/data_node.go 75.51% <100.00%> (-6.70%) ⬇️
internal/datanode/metrics_info.go 92.00% <100.00%> (ø)
internal/datanode/pipeline/flow_graph_dd_node.go 92.54% <100.00%> (ø)
...atanode/pipeline/flow_graph_dmstream_input_node.go 93.54% <100.00%> (ø)
internal/datanode/pipeline/flow_graph_message.go 100.00% <100.00%> (ø)
... and 18 more

... and 34 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 20, 2024
@jaime0815 jaime0815 mentioned this pull request Jun 21, 2024
Open
46 tasks
@jaime0815 jaime0815 force-pushed the refactor-dn-module branch from d1cdabe to 42dae05 Compare June 24, 2024 09:22
@mergify mergify bot removed the ci-passed label Jun 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 24, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 24, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the refactor-dn-module branch from 42dae05 to 0addfae Compare June 24, 2024 09:55
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 24, 2024

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@jaime0815
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Jun 24, 2024
@jaime0815
Copy link
Contributor Author

rerun ut

@mergify mergify bot added ci-passed and removed ci-passed labels Jun 25, 2024
@jaime0815 jaime0815 force-pushed the refactor-dn-module branch from 0addfae to ba2f7c9 Compare June 27, 2024 07:31
@mergify mergify bot removed the ci-passed label Jun 27, 2024
@jaime0815 jaime0815 force-pushed the refactor-dn-module branch from ba2f7c9 to 7a46c90 Compare June 28, 2024 07:39
@jaime0815 jaime0815 force-pushed the refactor-dn-module branch from 7a46c90 to 408434e Compare June 28, 2024 14:17
@mergify mergify bot added the ci-passed label Jun 28, 2024
congqixia
congqixia approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d6afb31 into milvus-io:master Jul 1, 2024
12 checks passed
@jaime0815 jaime0815 deleted the refactor-dn-module branch July 1, 2024 06:55
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@jaime0815 @yellow-shine
enhance: make subfunctions of datanode component modular (milvus-io#3…
d5ff345 
…3992)

issue: milvus-io#33994

also remove deprecated channel manager based on the etcd implementation

Signed-off-by: jaime <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@bigsheeper bigsheeper

@congqixia congqixia

Labels
approved area/compilation area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaime0815 @bigsheeper @sre-ci-robot @congqixia