Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Remove useless logic which block nodeUp progress #33917

Closed
wants to merge 1 commit into from
Closed

enhance: Remove useless logic which block nodeUp progress #33917

wants to merge 1 commit into from

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Jun 17, 2024 •
edited
Loading

issue: #34054

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement do-not-merge/missing-related-issue labels Jun 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 17, 2024

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@weiliu1031 weiliu1031 force-pushed the remove_nodeUp_logic branch from a5e0de9 to 174d0bd Compare June 18, 2024 03:50
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 18, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the remove_nodeUp_logic branch from 174d0bd to 502e709 Compare June 20, 2024 06:02
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 20, 2024

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the remove_nodeUp_logic branch 2 times, most recently from 34252f6 to 50ff970 Compare June 28, 2024 03:10
@weiliu1031
Copy link
Contributor Author

rerun ut

1 similar comment
@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031 weiliu1031 force-pushed the remove_nodeUp_logic branch from 50ff970 to b9f8de0 Compare July 16, 2024 07:05
@weiliu1031
enhance: Remove useless logic which block nodeUp progress
2ae1094 
before we supported balance node between replicas, to avoid assign node
to unexpected replica due to dirty node exist, we block the nodeUp
progress until all dirty node down.

This PR remove useless logic which block nodeUp progress

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 force-pushed the remove_nodeUp_logic branch from b9f8de0 to 2ae1094 Compare July 24, 2024 07:52
@mergify mergify bot added the ci-passed label Jul 24, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.01%. Comparing base (a4d7da4) to head (2ae1094).
Report is 282 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33917      +/-   ##
==========================================
- Coverage   80.95%   80.01%   -0.95%     
==========================================
  Files        1185     1185              
  Lines      142758   143027     +269     
==========================================
- Hits       115569   114442    -1127     
- Misses      22782    24163    +1381     
- Partials     4407     4422      +15
Files with missing lines Coverage Δ
internal/querycoordv2/server.go 82.61% <100.00%> (-0.79%) ⬇️

... and 103 files with indirect coverage changes

@stale Stale
Copy link

stale bot commented Aug 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Aug 24, 2024
@mergify mergify bot removed the ci-passed label Aug 24, 2024
@stale stale bot closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@jiaoew1991 jiaoew1991 Awaiting requested review from jiaoew1991

Assignees
No one assigned
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines. stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiliu1031 @sre-ci-robot