Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: refactor variable column to reduce memory cost #33875

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Jun 14, 2024

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 14, 2024
@zhagnlu zhagnlu changed the title enhance: refactor mmap variable column to reduce memory cost enhance: refactor variable column to reduce memory cost Jun 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 14, 2024
@zhagnlu zhagnlu force-pushed the enhance_variable_memory branch 2 times, most recently from 87e6ca1 to 48507f0 Compare June 14, 2024 09:42
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 79.86577% with 30 lines in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (96dcee5) to head (4bbebda).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33875      +/-   ##
==========================================
- Coverage   80.84%   79.27%   -1.58%     
==========================================
  Files        1085     1081       -4     
  Lines      137510   137960     +450     
==========================================
- Hits       111171   109368    -1803     
- Misses      22114    24358    +2244     
- Partials     4225     4234       +9     
Files Coverage Δ
internal/core/src/common/Common.h 100.00% <100.00%> (ø)
internal/core/src/common/EasyAssert.h 35.29% <ø> (-48.04%) ⬇️
internal/core/src/exec/expression/ExistsExpr.cpp 83.33% <ø> (-0.67%) ⬇️
internal/core/src/exec/expression/Expr.h 83.11% <100.00%> (+0.38%) ⬆️
...rnal/core/src/exec/expression/JsonContainsExpr.cpp 89.18% <ø> (-3.96%) ⬇️
internal/core/src/query/GroupByOperator.h 80.85% <100.00%> (-1.15%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.h 65.00% <ø> (-15.00%) ⬇️
internal/core/src/exec/expression/CompareExpr.cpp 84.00% <0.00%> (-1.06%) ⬇️
internal/core/src/segcore/SegmentInterface.h 91.66% <93.75%> (-8.34%) ⬇️
internal/core/src/common/File.h 90.90% <71.42%> (-9.10%) ⬇️
... and 5 more

... and 236 files with indirect coverage changes

internal/core/src/exec/expression/Expr.h Show resolved Hide resolved
internal/core/src/exec/expression/Expr.h Show resolved Hide resolved
internal/core/src/mmap/Column.h Outdated Show resolved Hide resolved
internal/core/src/mmap/Column.h Outdated Show resolved Hide resolved
internal/core/src/mmap/Column.h Outdated Show resolved Hide resolved
@zhagnlu zhagnlu force-pushed the enhance_variable_memory branch from 48507f0 to 2921bda Compare June 19, 2024 12:12
Copy link
Contributor

mergify bot commented Jun 19, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the enhance_variable_memory branch from 2921bda to 79d267b Compare June 20, 2024 07:21
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jun 21, 2024

rerun ut

2 similar comments
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jun 21, 2024

rerun ut

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jun 21, 2024

rerun ut

Copy link
Contributor

mergify bot commented Jun 24, 2024

@zhagnlu ut workflow job failed, comment rerun ut can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jun 24, 2024

rerun ut

@zhagnlu zhagnlu force-pushed the enhance_variable_memory branch from 79d267b to 70bb9d9 Compare June 24, 2024 11:23
Copy link
Contributor

mergify bot commented Jun 24, 2024

@zhagnlu ut workflow job failed, comment rerun ut can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jun 25, 2024

rerun ut

@mergify mergify bot added the ci-passed label Jun 25, 2024
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jun 27, 2024

rerun ut

@zhagnlu zhagnlu force-pushed the enhance_variable_memory branch from 70bb9d9 to c822f7f Compare June 27, 2024 07:52
@mergify mergify bot removed the ci-passed label Jun 27, 2024
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jun 28, 2024

rerun ut

@zhagnlu zhagnlu force-pushed the enhance_variable_memory branch from c822f7f to 4bbebda Compare June 28, 2024 10:47
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jun 30, 2024

rerun ut

@mergify mergify bot added the ci-passed label Jun 30, 2024
@czs007
Copy link
Collaborator

czs007 commented Jun 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3030e46 into milvus-io:master Jun 30, 2024
11 of 12 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Jul 2, 2024
zhagnlu added a commit to zhagnlu/milvus that referenced this pull request Jul 2, 2024
zhagnlu added a commit to zhagnlu/milvus that referenced this pull request Jul 3, 2024
zhagnlu added a commit to zhagnlu/milvus that referenced this pull request Jul 4, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 5, 2024
)

cherry-pick commit from master:
pr: #33875

Signed-off-by: luzhang <[email protected]>
Co-authored-by: luzhang <[email protected]>
@czs007 czs007 removed the PR | need cherry-pick need cherry pick to other branches label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants