Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wrap init segcore tracing with golang timeout #33494

Merged
merged 3 commits into from
Jun 3, 2024
Merged

fix: Wrap init segcore tracing with golang timeout #33494

merged 3 commits into from
Jun 3, 2024

Conversation

congqixia
Copy link
Contributor

See also #33483

Wrap C.InitTrace & C.SetTrace with timeout preventing otlp initializtion hangs forever when endpoint is not set correctly

@congqixia
fix: Wrap init segcore tracing with golang timeout
726438e 
See also milvus-io#33483

Wrap `C.InitTrace` & `C.SetTrace` with timeout preventing otlp
initializtion hangs forever when endpoint is not set correctly

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels May 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 30, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

@congqixia
Commit param item file
e5e180f 
Signed-off-by: Congqi Xia <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented May 30, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.96%. Comparing base (8f46a20) to head (595399e).
Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33494      +/-   ##
==========================================
- Coverage   82.14%   81.96%   -0.19%     
==========================================
  Files        1012     1013       +1     
  Lines      129269   129872     +603     
==========================================
+ Hits       106188   106448     +260     
- Misses      19090    19446     +356     
+ Partials     3991     3978      -13
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.51% <100.00%> (+0.01%) ⬆️
internal/core/src/common/Tracer.cpp 83.56% <50.00%> (ø)
internal/util/initcore/init_core.go 88.52% <82.60%> (-1.58%) ⬇️

... and 74 files with indirect coverage changes

@congqixia
Fix gci lint
595399e 
Signed-off-by: Congqi Xia <[email protected]>
@mergify mergify bot added the ci-passed label May 31, 2024
@aoiasd
Copy link
Contributor

aoiasd commented Jun 3, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 2b285e5 into milvus-io:master Jun 3, 2024
15 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Jun 26, 2024
@congqixia
fix: Wrap init segcore tracing with golang timeout (milvus-io#33494)
3017b59 
See also milvus-io#33483

Wrap `C.InitTrace` & `C.SetTrace` with timeout preventing otlp
initializtion hangs forever when endpoint is not set correctly

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Jun 26, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Jun 26, 2024
@congqixia
fix: [2.4] Wrap init segcore tracing with golang timeout (#33494) (#3…
07a05db 
…4191)

Cherry-pick from master
pr: #33494
See also #33483

Wrap `C.InitTrace` & `C.SetTrace` with timeout preventing otlp
initializtion hangs forever when endpoint is not set correctly

Signed-off-by: Congqi Xia <[email protected]>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@congqixia @yellow-shine
fix: Wrap init segcore tracing with golang timeout (milvus-io#33494)
3c74c18 
See also milvus-io#33483

Wrap `C.InitTrace` & `C.SetTrace` with timeout preventing otlp
initializtion hangs forever when endpoint is not set correctly

---------

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@aoiasd aoiasd

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @aoiasd