enhance: update knowhere version #33490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Buqian Zheng <[email protected]>
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33490 +/- ##
==========================================
- Coverage 82.23% 82.18% -0.05%
==========================================
Files 1006 1006
Lines 129986 129983 -3
==========================================
- Hits 106888 106831 -57
- Misses 19132 19174 +42
- Partials 3966 3978 +12
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
May 31, 2024
issue: #33489 pr: #33490 update knowhere version to latest. remove usage of seed_ef as it be replaced by existing ef. Signed-off-by: Buqian Zheng <[email protected]>
yellow-shine
pushed a commit
to yellow-shine/milvus
that referenced
this pull request
Jul 2, 2024
issue: milvus-io#33489 update knowhere version to latest. remove usage of `seed_ef` as it be replaced by existing `ef`. Signed-off-by: Buqian Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #33489
update knowhere version to latest. remove usage of
seed_efas it be replaced by existingef.