Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: disable azure compilation by default #31918

Closed

Conversation

xiaofan-luan
Copy link
Collaborator

@xiaofan-luan xiaofan-luan commented Apr 4, 2024

fix #31917

  1. remove unnecessary dependencies
  2. ideally this could improve the compilation speed and accelerate CI/CDs

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 4, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan
Copy link
Collaborator Author

@LoveEachDay
Need your help to verify all the pipepline with Azure actually works

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (0feee53) to head (ff0aa21).
Report is 663 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31918      +/-   ##
==========================================
- Coverage   81.05%   80.80%   -0.26%     
==========================================
  Files         979      977       -2     
  Lines      140705   140543     -162     
==========================================
- Hits       114050   113562     -488     
- Misses      22862    23182     +320     
- Partials     3793     3799       +6     

see 53 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator Author

@samhuang-z
also this pr spend a lot of time on code checker and build && test.
Is there a way we can accelerate?

Copy link

stale bot commented May 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label May 5, 2024
@stale stale bot closed this May 12, 2024
@czs007 czs007 reopened this Jun 24, 2024
@stale stale bot removed the stale indicates no udpates for 30 days label Jun 24, 2024
@mergify mergify bot removed the ci-passed label Jun 24, 2024
Copy link
Contributor

mergify bot commented Jun 24, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 24, 2024

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance]: Disable Azure build and vcpkg install by default
3 participants