Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow datanode's server id to be updated #31597

Merged
merged 1 commit into from
May 8, 2024

Conversation

yiwangdr
Copy link
Contributor

@yiwangdr yiwangdr commented Mar 25, 2024

issue: #31516

background: the server id field in data node is redundant. session id already provides the source of truth.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 25, 2024
@sre-ci-robot sre-ci-robot requested review from sunby and xige-16 March 25, 2024 19:28
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 25, 2024
Copy link
Contributor

mergify bot commented Mar 25, 2024

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yiwangdr yiwangdr requested review from XuanYang-cn, weiliu1031 and congqixia and removed request for xige-16 March 25, 2024 19:52
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.75%. Comparing base (c0555d4) to head (37a41cf).
Report is 60 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #31597   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         998      998           
  Lines      124172   124175    +3     
=======================================
+ Hits       101519   101525    +6     
+ Misses      18792    18782   -10     
- Partials     3861     3868    +7     
Files Coverage Δ
internal/datanode/data_node.go 81.33% <100.00%> (-0.09%) ⬇️
internal/datanode/event_manager.go 82.64% <100.00%> (ø)
internal/distributed/datanode/service.go 82.92% <100.00%> (ø)
internal/datacoord/server.go 71.62% <75.00%> (+0.02%) ⬆️
internal/distributed/datacoord/service.go 88.83% <50.00%> (ø)

... and 29 files with indirect coverage changes

@yiwangdr
Copy link
Contributor Author

rerun ut

@yiwangdr
Copy link
Contributor Author

yiwangdr commented Apr 2, 2024

rerun ut

Copy link
Contributor

mergify bot commented Apr 10, 2024

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 10, 2024

@yiwangdr ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 11, 2024

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yiwangdr
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 11, 2024

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yiwangdr
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 11, 2024
@czs007
Copy link
Collaborator

czs007 commented Apr 28, 2024

/run-cpu-e2e

@mergify mergify bot removed the ci-passed label Apr 28, 2024
Copy link
Contributor

mergify bot commented Apr 28, 2024

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@XuanYang-cn
Copy link
Contributor

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 28, 2024

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: XuanYang-cn, yiwangdr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d6e537c into milvus-io:master May 8, 2024
15 checks passed
@yiwangdr yiwangdr deleted the yiwang/debug branch May 8, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants