-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow datanode's server id to be updated #31597
Conversation
@yiwangdr E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31597 +/- ##
=======================================
Coverage 81.75% 81.75%
=======================================
Files 998 998
Lines 124172 124175 +3
=======================================
+ Hits 101519 101525 +6
+ Misses 18792 18782 -10
- Partials 3861 3868 +7
|
rerun ut |
rerun ut |
@yiwangdr E2e jenkins job failed, comment |
@yiwangdr ut workflow job failed, comment |
@yiwangdr E2e jenkins job failed, comment |
/run-cpu-e2e |
@yiwangdr E2e jenkins job failed, comment |
/run-cpu-e2e |
/run-cpu-e2e |
@yiwangdr E2e jenkins job failed, comment |
/lgtm |
/run-cpu-e2e |
@yiwangdr E2e jenkins job failed, comment |
Signed-off-by: yiwangdr <[email protected]>
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: XuanYang-cn, yiwangdr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #31516
background: the server id field in data node is redundant. session id already provides the source of truth.