Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix conan version in DEVELOPMENT.md #31414

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

ashkrisk
Copy link
Contributor

The conan version used in all the setup scripts was updated to 1.61.0 in #27870. However, a line in the developer documentation was left out.

Since the dependencies no longer install correctly with conan 1.58 (#27869), all documentation should consistently use the updated version.

Signed-off-by: Ashwin Krishna Kumar <[email protected]>
@sre-ci-robot
Copy link
Contributor

Welcome @ashkrisk! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 19, 2024
Copy link
Contributor

mergify bot commented Mar 19, 2024

@ashkrisk

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@ashkrisk ashkrisk changed the title Fix conan version in DEVELOPMENT.md doc: fix conan version in DEVELOPMENT.md Mar 19, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashkrisk, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1c55016 into milvus-io:master Mar 20, 2024
3 checks passed
@ashkrisk ashkrisk deleted the conan-version-devdoc-fix branch March 20, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/doc lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants