Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix search failed when empty segment exist #27922

Closed
wants to merge 1 commit into from
Closed

fix search failed when empty segment exist #27922

wants to merge 1 commit into from

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Oct 25, 2023 •
edited
Loading

issue: #27913

the skip empty logic will return SegmentNotLoaded when meet empty segment, fix it
/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Oct 25, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 25, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 25, 2023
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the fix_search_failed_when_empty_segment_exist branch from b6843fb to c13ca0e Compare October 25, 2023 10:55
@sre-ci-robot sre-ci-robot removed the lgtm label Oct 25, 2023
congqixia
congqixia approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the fix_search_failed_when_empty_segment_exist branch from c13ca0e to 573194d Compare October 25, 2023 13:33
@sre-ci-robot sre-ci-robot removed the lgtm label Oct 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the fix_search_failed_when_empty_segment_exist branch from 573194d to eb5fba5 Compare October 25, 2023 14:29
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Oct 25, 2023
congqixia
congqixia approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weiliu1031 weiliu1031 force-pushed the fix_search_failed_when_empty_segment_exist branch from eb5fba5 to 383ad10 Compare October 25, 2023 16:13
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Oct 25, 2023
@weiliu1031
Copy link
Contributor Author

/hold

@weiliu1031
Copy link
Contributor Author

/unhold

@weiliu1031
Copy link
Contributor Author

empty growing/sealed segment in query node is invalid, and we should avoid add empty growing/sealed segment to delegator's distribution. if search/query request to read a empty segment, which is also regard as released segment, it should return a SegmentNotLoaded error.

see also #27930

@weiliu1031
Copy link
Contributor Author

/hold

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #27922 (383ad10) into master (53246b1) will increase coverage by 0.02%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27922      +/-   ##
==========================================
+ Coverage   81.77%   81.80%   +0.02%     
==========================================
  Files         821      821              
  Lines      116330   116323       -7     
==========================================
+ Hits        95126    95153      +27     
+ Misses      18048    18023      -25     
+ Partials     3156     3147       -9
Files Coverage Δ
internal/querynodev2/segments/manager.go 90.16% <100.00%> (+2.63%) ⬆️

... and 23 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 25, 2023
@weiliu1031 weiliu1031 closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@aoiasd aoiasd Awaiting requested review from aoiasd

Assignees

@xiaofan-luan xiaofan-luan

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/hold kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiliu1031 @xiaofan-luan @sre-ci-robot @congqixia