Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify service providers based on addresses #27907

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Identify service providers based on addresses #27907

merged 1 commit into from
Oct 25, 2023

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented Oct 25, 2023

issue #27905

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Oct 25, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 25, 2023
@czs007
Copy link
Collaborator Author

czs007 commented Oct 25, 2023 •
edited
Loading

TODO: deprecate the MinioChunkManager or refactor it based on the MinioObjectStore.

longjiquan
longjiquan approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@czs007 ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot removed the lgtm label Oct 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #27907 (5e1f1ca) into master (a951c75) will increase coverage by 0.01%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27907      +/-   ##
==========================================
+ Coverage   81.75%   81.77%   +0.01%     
==========================================
  Files         821      821              
  Lines      116330   116304      -26     
==========================================
- Hits        95108    95105       -3     
+ Misses      18064    18048      -16     
+ Partials     3158     3151       -7
Files Coverage Δ
internal/storage/aliyun/aliyun.go 100.00% <ø> (ø)
internal/storage/minio_chunk_manager.go 74.51% <100.00%> (+4.95%) ⬆️
internal/storage/minio_object_storage.go 76.19% <51.51%> (-8.92%) ⬇️

... and 13 files with indirect coverage changes

@czs007
Copy link
Collaborator Author

czs007 commented Oct 25, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator Author

czs007 commented Oct 25, 2023

/run-cpu-e2e

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Oct 25, 2023
longjiquan
longjiquan approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6c3f29d into milvus-io:master Oct 25, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longjiquan longjiquan longjiquan approved these changes

@sunby sunby Awaiting requested review from sunby

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@longjiquan longjiquan

Labels
approved ci-passed dco-passed DCO check passed. lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@czs007 @sre-ci-robot @longjiquan @yanliang567