Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mmap for IVF index #27904

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Enable mmap for IVF index #27904

merged 1 commit into from
Oct 25, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Oct 25, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 25, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 25, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 25, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #27904 (bb1569c) into master (53246b1) will increase coverage by 0.00%.
Report is 7 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #27904   +/-   ##
=======================================
  Coverage   81.77%   81.77%           
=======================================
  Files         821      812    -9     
  Lines      116330   116260   -70     
=======================================
- Hits        95126    95074   -52     
+ Misses      18048    18029   -19     
- Partials     3156     3157    +1
Files Coverage Δ
internal/core/src/index/Index.h 100.00% <100.00%> (+8.33%) ⬆️

... and 165 files with indirect coverage changes

@yah01
Copy link
Member Author

yah01 commented Oct 25, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 25, 2023
@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a36a57b into milvus-io:master Oct 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@jiaoew1991 jiaoew1991

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @jiaoew1991 @sre-ci-robot