Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]reduce compact parallel task num #27900

Merged

Conversation

weiliu1031
Copy link
Contributor

pr: #27899

/kind improvement

to reduce the memory cost during compact, reduce the compact parallel task num

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 24, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 24, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 24, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #27900 (141cbec) into 2.2.0 (ce17962) will decrease coverage by 0.01%.
Report is 1 commits behind head on 2.2.0.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #27900      +/-   ##
==========================================
- Coverage   80.96%   80.96%   -0.01%     
==========================================
  Files         745      745              
  Lines      109255   109254       -1     
==========================================
- Hits        88459    88457       -2     
- Misses      17446    17452       +6     
+ Partials     3350     3345       -5     
Files Coverage Δ
internal/datanode/flow_graph_dd_node.go 82.62% <100.00%> (+0.92%) ⬆️
internal/util/paramtable/component_param.go 87.37% <100.00%> (ø)

... and 14 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 24, 2023
@sre-ci-robot sre-ci-robot merged commit ba297d1 into milvus-io:2.2.0 Oct 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants