Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Refine stop order #27898

Closed
wants to merge 1 commit into from

Conversation

weiliu1031
Copy link
Contributor

pr: #27897

@sre-ci-robot sre-ci-robot requested review from czs007 and sunby October 24, 2023 13:38
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 24, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #27898 (0c193a2) into 2.2.0 (ce17962) will decrease coverage by 0.02%.
Report is 2 commits behind head on 2.2.0.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #27898      +/-   ##
==========================================
- Coverage   80.96%   80.95%   -0.02%     
==========================================
  Files         745      745              
  Lines      109255   109265      +10     
==========================================
- Hits        88459    88454       -5     
- Misses      17446    17459      +13     
- Partials     3350     3352       +2     
Files Coverage Δ
internal/datanode/flow_graph_dd_node.go 82.62% <100.00%> (+0.92%) ⬆️
internal/distributed/querynode/service.go 81.04% <76.92%> (-0.46%) ⬇️

... and 13 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 24, 2023
Signed-off-by: Wei Liu <[email protected]>
@mergify mergify bot removed the ci-passed label Oct 24, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Oct 25, 2023
@weiliu1031
Copy link
Contributor Author

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. do-not-merge/hold size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants