Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization and backward compatibility issue for GRPC compression #27894

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Oct 24, 2023

issue: #27887

RPC send fails during the rolling upgrade if client compression has already been enabled but the server doesn't config compression.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 24, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 24, 2023
@jaime0815 jaime0815 added this to the 2.3.2 milestone Oct 24, 2023
@czs007
Copy link
Collaborator

czs007 commented Oct 24, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #27894 (f8200cb) into master (b9d5ef3) will decrease coverage by 0.04%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27894      +/-   ##
==========================================
- Coverage   81.80%   81.76%   -0.04%     
==========================================
  Files         821      821              
  Lines      116330   116330              
==========================================
- Hits        95159    95119      -40     
- Misses      18018    18052      +34     
- Partials     3153     3159       +6     
Files Coverage Δ
internal/distributed/datacoord/service.go 87.91% <ø> (ø)
internal/distributed/datanode/service.go 81.94% <ø> (ø)
internal/distributed/indexnode/service.go 70.80% <ø> (ø)
internal/distributed/proxy/service.go 81.33% <ø> (+0.69%) ⬆️
internal/distributed/querycoord/service.go 73.63% <ø> (ø)
internal/distributed/querynode/service.go 80.19% <ø> (ø)
internal/distributed/rootcoord/service.go 79.92% <ø> (ø)
pkg/util/paramtable/grpc_param.go 81.48% <ø> (ø)

... and 20 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 24, 2023
@sre-ci-robot sre-ci-robot merged commit 4640928 into milvus-io:master Oct 24, 2023
12 checks passed
@jaime0815 jaime0815 deleted the fix-grpc-compression-error branch October 24, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants