Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize delete records memory usage #27855

Closed
wants to merge 1 commit into from

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Oct 23, 2023

/kind improvement
related #27253

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 23, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yah01
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Oct 23, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 23, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 23, 2023

I found a bug while testing this PR, and this improvement could fix it, mark it as /kind bug also

@yah01
Copy link
Member Author

yah01 commented Oct 23, 2023

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Oct 23, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 23, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #27855 (c01b06a) into master (53246b1) will decrease coverage by 0.04%.
Report is 387 commits behind head on master.
The diff coverage is 78.94%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27855      +/-   ##
==========================================
- Coverage   81.77%   81.73%   -0.04%     
==========================================
  Files         821      812       -9     
  Lines      116330   116320      -10     
==========================================
- Hits        95126    95073      -53     
- Misses      18048    18091      +43     
  Partials     3156     3156              
Files Coverage Δ
internal/core/src/segcore/DeletedRecord.h 97.95% <100.00%> (-0.05%) ⬇️
internal/core/src/segcore/SegmentGrowingImpl.h 80.35% <ø> (+0.35%) ⬆️
internal/core/src/segcore/Utils.h 100.00% <100.00%> (ø)
internal/core/src/segcore/InsertRecord.h 86.61% <83.33%> (-5.17%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.cpp 74.96% <90.74%> (-0.23%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.h 69.04% <54.16%> (-19.19%) ⬇️
internal/core/src/segcore/SegmentGrowingImpl.cpp 80.45% <70.37%> (-3.77%) ⬇️

... and 157 files with indirect coverage changes

@yah01
Copy link
Member Author

yah01 commented Oct 24, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 25, 2023

rerun ut

1 similar comment
@yah01
Copy link
Member Author

yah01 commented Oct 25, 2023

rerun ut

@yah01
Copy link
Member Author

yah01 commented Nov 10, 2023

/hold
This optimization conflicts to L0 segment design, hold it for now and redesign this

Copy link
Contributor

mergify bot commented Nov 16, 2023

@yah01

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • enhance: for improvements to existing functionality.
  • fix: for bug fixes.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, enhance, or fix.

Example:

feat: Enhance search functionality within the user interface

Please review and update your PR to comply with these guidelines.

Copy link

stale bot commented Dec 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 16, 2023
@yah01
Copy link
Member Author

yah01 commented Dec 20, 2023

this can't be done after the level 0 segment introduced, close it

@yah01 yah01 closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. do-not-merge/hold do-not-merge/invalid-pr-format kind/bug Issues or changes related a bug kind/improvement Changes related to something improve, likes ut and code refactor size/XL Denotes a PR that changes 500-999 lines. stale indicates no udpates for 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants