New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the goroutine in flowgraph to 2 #27727

Closed

smellthemoon wants to merge 1 commit into milvus-io:master from smellthemoon:goroutine-limit

Contributor

smellthemoon commented Oct 16, 2023

#24826
/kind improvement

sre-ci-robot added the kind/improvement label

sre-ci-robot requested review from czs007 and XuanYang-cn

October 16, 2023 11:08

sre-ci-robot added the size/S label

Contributor

sre-ci-robot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mergify bot added the dco-passed label

Contributor

mergify bot commented Oct 16, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from 1005691 to cb8d4cc Compare

October 16, 2023 11:30

Contributor

mergify bot commented Oct 16, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from cb8d4cc to 6015f5c Compare

October 17, 2023 12:06

Contributor

mergify bot commented Oct 17, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

yah01 suggested changes

View reviewed changes

internal/datanode/data_sync_service.go Outdated Show resolved Hide resolved

internal/util/flowgraph/node.go Outdated Show resolved Hide resolved

smellthemoon force-pushed the goroutine-limit branch from 6015f5c to c0b9686 Compare

October 23, 2023 13:58

sre-ci-robot added size/M and removed size/S labels

Contributor

mergify bot commented Oct 23, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from c0b9686 to fdb8458 Compare

October 24, 2023 12:19

sre-ci-robot added area/dependency size/L and removed size/M labels

smellthemoon force-pushed the goroutine-limit branch 5 times, most recently from 9cb4675 to 4e203f7 Compare

October 24, 2023 12:47

Contributor

mergify bot commented Oct 24, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented Oct 24, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from 4e203f7 to 5beffb6 Compare

October 25, 2023 04:45

Contributor

mergify bot commented Oct 25, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented Oct 25, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from a6e7fe6 to bd454b2 Compare

October 31, 2023 03:09

Contributor

mergify bot commented Oct 31, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from bd454b2 to b43f716 Compare

November 1, 2023 09:45

Contributor

mergify bot commented Nov 1, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented Nov 1, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from b43f716 to 7a49c64 Compare

November 1, 2023 12:32

Contributor

mergify bot commented Nov 1, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented Nov 1, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from 7a49c64 to 1fe077e Compare

November 1, 2023 14:27

Contributor

mergify bot commented Nov 1, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented Nov 1, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from 1fe077e to a31cbd8 Compare

November 2, 2023 06:20

Contributor

mergify bot commented Nov 2, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented Nov 2, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from a31cbd8 to 7593df6 Compare

November 3, 2023 10:05

Contributor

mergify bot commented Nov 3, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor

mergify bot commented Nov 3, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

smellthemoon force-pushed the goroutine-limit branch from 7593df6 to edbd2a0 Compare

November 7, 2023 03:58

Contributor

mergify bot commented Nov 7, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

Contributor

mergify bot commented Nov 7, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.


          Reduce the goroutine in flowgraph to 2

8ce1e90

Signed-off-by: lixinguo <[email protected]>

smellthemoon force-pushed the goroutine-limit branch from edbd2a0 to 8ce1e90 Compare

November 7, 2023 06:32

Contributor

mergify bot commented Nov 7, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

Contributor

mergify bot commented Nov 7, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

smellthemoon closed this

mergify bot added needs-dco and removed dco-passed labels

Contributor

mergify bot commented Apr 24, 2024

@smellthemoon Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify bot added the do-not-merge/invalid-pr-format label

Contributor

mergify bot commented Apr 24, 2024

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

Title Format: The PR title must begin with one of these prefixes:

feat: for introducing a new feature.
fix: for bug fixes.
enhance: for improvements to existing functionality.
test: for add tests to existing functionality.
doc: for modifying documentation.
auto: for the pull request from bot.

Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency do-not-merge/invalid-pr-format kind/improvement needs-dco size/L