Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing too many warnings (#27015) #27669

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

longjiquan
Copy link
Contributor

/kind bug
/kind improvement
pr: #27015

@sre-ci-robot sre-ci-robot added kind/bug Issues or changes related a bug kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines. labels Oct 12, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 12, 2023
@czs007
Copy link
Collaborator

czs007 commented Oct 12, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #27669 (ad16c56) into 2.2.0 (19ee108) will increase coverage by 0.01%.
Report is 2 commits behind head on 2.2.0.
The diff coverage is 58.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #27669      +/-   ##
==========================================
+ Coverage   80.94%   80.95%   +0.01%     
==========================================
  Files         745      745              
  Lines      109226   109237      +11     
==========================================
+ Hits        88416    88436      +20     
+ Misses      17457    17450       -7     
+ Partials     3353     3351       -2     
Files Coverage Δ
internal/util/flowgraph/node.go 75.26% <100.00%> (+1.11%) ⬆️
internal/datacoord/util.go 78.82% <54.34%> (-1.55%) ⬇️

... and 12 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Oct 13, 2023

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Oct 13, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit 350fcc0 into milvus-io:2.2.0 Oct 13, 2023
8 of 9 checks passed
@longjiquan longjiquan deleted the cp-27015 branch October 15, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants