Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine chunk manager errors #27590

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Refine chunk manager errors #27590

merged 1 commit into from
Oct 31, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Oct 10, 2023

/kind improvement
related #27490

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/L Denotes a PR that changes 100-499 lines. labels Oct 10, 2023
@sre-ci-robot sre-ci-robot requested review from czs007 and sunby October 10, 2023 04:33
@mergify mergify bot added the dco-passed DCO check passed. label Oct 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #27590 (1440df7) into master (233bf90) will increase coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is 80.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27590      +/-   ##
==========================================
+ Coverage   81.77%   81.80%   +0.02%     
==========================================
  Files         829      829              
  Lines      116993   116999       +6     
==========================================
+ Hits        95673    95708      +35     
+ Misses      18140    18120      -20     
+ Partials     3180     3171       -9
Files Coverage Δ
internal/core/src/storage/ThreadPool.cpp 100.00% <100.00%> (ø)
internal/core/src/storage/ThreadPool.h 100.00% <100.00%> (ø)
internal/core/src/storage/ThreadPools.cpp 100.00% <100.00%> (ø)
internal/datanode/channel_meta.go 93.17% <100.00%> (+0.47%) ⬆️
internal/distributed/proxy/service.go 80.66% <100.00%> (+0.69%) ⬆️
internal/storage/azure_object_storage.go 92.68% <100.00%> (ø)
internal/util/sessionutil/session_util.go 80.15% <100.00%> (+0.38%) ⬆️
pkg/util/merr/utils.go 89.13% <100.00%> (ø)
pkg/util/paramtable/base_table.go 78.98% <ø> (ø)
internal/storage/remote_chunk_manager.go 82.03% <96.66%> (+2.50%) ⬆️
... and 4 more

... and 15 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01 yah01 force-pushed the refine-cm-errros branch 2 times, most recently from 39ba135 to 34b897c Compare October 25, 2023 11:13
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot sre-ci-robot removed the lgtm label Oct 26, 2023
@yah01 yah01 force-pushed the refine-cm-errros branch 2 times, most recently from 64f0cdb to f07522b Compare October 30, 2023 06:52
@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 30, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added the ci-passed label Oct 31, 2023
@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9658367 into milvus-io:master Oct 31, 2023
12 checks passed
BandhiyaHardik pushed a commit to BandhiyaHardik/milvus that referenced this pull request Oct 31, 2023
@yah01 @BandhiyaHardik
Refine chunk manager errors (milvus-io#27590)
4fc32f7 
Signed-off-by: yah01 <[email protected]>
Signed-off-by: BandhiyaHardik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@sunby sunby Awaiting requested review from sunby

Assignees

@jiaoew1991 jiaoew1991

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @jiaoew1991 @sre-ci-robot