Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support llvm17 on MacOS #27582

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Support llvm17 on MacOS #27582

merged 1 commit into from
Oct 10, 2023

Conversation

jiaoew1991
Copy link
Contributor

/kind improvement

@jiaoew1991
Support llvm17 on MacOS
ef7f8e8 
Signed-off-by: Enwei Jiao <[email protected]>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor approved labels Oct 9, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 9, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #27582 (ef7f8e8) into master (cb71a3e) will decrease coverage by 0.01%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27582      +/-   ##
==========================================
- Coverage   81.46%   81.46%   -0.01%     
==========================================
  Files         804      804              
  Lines      114240   114240              
==========================================
- Hits        93066    93063       -3     
  Misses      18035    18035              
- Partials     3139     3142       +3

see 15 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

should we change to llvm_version >= 14

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiaoew1991
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiaoew1991
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 10, 2023
@sre-ci-robot sre-ci-robot merged commit 42db013 into milvus-io:master Oct 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

@yhmo yhmo Awaiting requested review from yhmo

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiaoew1991 @xiaofan-luan @sre-ci-robot