Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip e2e] Fix var-naming caused by old PRs #27501

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

congqixia
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor approved labels Oct 7, 2023
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 7, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@yah01
Copy link
Member

yah01 commented Oct 7, 2023

/lgtm

@congqixia congqixia force-pushed the fix_lint_issue_conflict branch from 449bbeb to 6dfd7d6 Compare October 7, 2023 06:20
@sre-ci-robot sre-ci-robot removed the lgtm label Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #27501 (449bbeb) into master (8394b3a) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

❗ Current head 449bbeb differs from pull request most recent head 6dfd7d6. Consider uploading reports for the commit 6dfd7d6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27501      +/-   ##
==========================================
- Coverage   81.48%   81.46%   -0.03%     
==========================================
  Files         802      802              
  Lines      114571   114571              
==========================================
- Hits        93360    93334      -26     
- Misses      18038    18062      +24     
- Partials     3173     3175       +2     
Files Coverage Δ
internal/datanode/data_sync_service.go 84.40% <100.00%> (ø)
pkg/util/merr/utils.go 91.97% <100.00%> (ø)
internal/datanode/flow_graph_time_tick_node.go 85.86% <0.00%> (ø)

... and 12 files with indirect coverage changes

@congqixia congqixia changed the title Fix var-naming and gofumpt issue caused by old PRs [skip e2e] Fix var-naming caused by old PRs Oct 7, 2023
@sre-ci-robot sre-ci-robot removed the size/L Denotes a PR that changes 100-499 lines. label Oct 7, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 7, 2023
@mergify mergify bot added the ci-passed label Oct 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member

yah01 commented Oct 7, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit 80eb543 into milvus-io:master Oct 7, 2023
9 checks passed
@congqixia congqixia deleted the fix_lint_issue_conflict branch October 10, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants