Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error message for getting all indexes of collection #27389

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Improve the error message for getting all indexes of collection #27389

merged 1 commit into from
Oct 8, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Sep 27, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Sep 27, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Sep 27, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #27389 (5a6ac66) into master (41124f2) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is 92.29%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #27389   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files         801      801           
  Lines      113794   113817   +23     
=======================================
+ Hits        92653    92679   +26     
- Misses      18005    18010    +5     
+ Partials     3136     3128    -8
Files Coverage Δ
internal/datacoord/index_service.go 94.07% <100.00%> (-0.04%) ⬇️
pkg/util/merr/utils.go 93.43% <100.00%> (+1.46%) ⬆️
pkg/util/typeutil/gen_empty_field_data.go 100.00% <100.00%> (ø)
pkg/util/typeutil/schema.go 80.99% <100.00%> (+0.09%) ⬆️
internal/proxy/task_index.go 76.98% <12.50%> (-0.35%) ⬇️
internal/proxy/default_limit_reducer.go 68.08% <52.63%> (-1.15%) ⬇️
internal/proxy/task.go 85.50% <94.07%> (+0.17%) ⬆️

... and 18 files with indirect coverage changes

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@yah01 yah01 force-pushed the fix-err-msg branch 2 times, most recently from b34c9ed to af2d971 Compare September 27, 2023 07:00
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 27, 2023
congqixia
congqixia requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this could fix the problem, please check comment

internal/datacoord/index_service.go Outdated Show resolved Hide resolved
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Sep 27, 2023
@mergify mergify bot removed the ci-passed label Sep 27, 2023
congqixia
congqixia reviewed Sep 27, 2023
View reviewed changes
pkg/util/merr/utils.go Outdated Show resolved Hide resolved
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Sep 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Oct 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 7, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 7, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 7, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 7, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 7, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01 yah01 force-pushed the fix-err-msg branch 2 times, most recently from eb7cb09 to d4b691c Compare October 8, 2023 07:32
@mergify mergify bot added the ci-passed label Oct 8, 2023
congqixia
congqixia reviewed Oct 8, 2023
View reviewed changes
internal/proxy/task.go Outdated Show resolved Hide resolved
congqixia
congqixia reviewed Oct 8, 2023
View reviewed changes
internal/proxy/task_index.go
Comment on lines +503 to +504
err = merr.WrapErrIndexNotFoundForCollection(dit.GetCollectionName())
dit.result.Status = merr.Status(err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composing an error and convert it into status looks awkward here, maybe add a helper method later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's rewriting the error with the helper info

@mergify mergify bot removed the ci-passed label Oct 8, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 8, 2023

/run-cpu-e2e

congqixia
congqixia approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Oct 8, 2023
@sre-ci-robot sre-ci-robot merged commit 41495ed into milvus-io:master Oct 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @sre-ci-robot @congqixia