Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record engine version for segment index #27384

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

longjiquan
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor area/internal-api size/XL Denotes a PR that changes 500-999 lines. labels Sep 26, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #27384 (94325ee) into master (a8ce1b6) will decrease coverage by 0.02%.
Report is 5 commits behind head on master.
The diff coverage is 87.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27384      +/-   ##
==========================================
- Coverage   81.45%   81.44%   -0.02%     
==========================================
  Files         803      803              
  Lines      114586   114587       +1     
==========================================
- Hits        93335    93321      -14     
- Misses      18069    18080      +11     
- Partials     3182     3186       +4     
Files Coverage Δ
internal/datacoord/index_builder.go 91.98% <100.00%> (ø)
internal/datacoord/index_meta.go 99.25% <100.00%> (+<0.01%) ⬆️
internal/datacoord/index_service.go 94.10% <100.00%> (-0.07%) ⬇️
internal/indexnode/indexnode_service.go 86.55% <100.00%> (+0.05%) ⬆️
internal/indexnode/taskinfo_ops.go 78.21% <100.00%> (+0.21%) ⬆️
internal/metastore/model/segment_index.go 95.23% <ø> (-0.22%) ⬇️
internal/querycoordv2/meta/coordinator_broker.go 67.42% <ø> (-0.19%) ⬇️
internal/querynodev2/segments/segment_loader.go 74.21% <ø> (-0.29%) ⬇️
internal/indexnode/task.go 38.43% <66.66%> (+0.20%) ⬆️
internal/datacoord/server.go 69.30% <66.66%> (ø)
... and 1 more

... and 12 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Sep 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 28, 2023
@czs007
Copy link
Collaborator

czs007 commented Sep 28, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 370fdaf into milvus-io:master Sep 28, 2023
12 checks passed
@longjiquan longjiquan deleted the record-index-version branch October 7, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants