Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query_coord.proto comment format caused lint issue #27375

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

congqixia
Copy link
Contributor

block comment in query_coord.proto has no blank line after, which caused generated .pb.go file has lint issue
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Sep 26, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested a review from czs007 September 26, 2023 10:03
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Sep 26, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #27375 (aafd5a0) into master (6539a5a) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #27375   +/-   ##
=======================================
  Coverage   81.50%   81.51%           
=======================================
  Files         801      801           
  Lines      114371   114371           
=======================================
+ Hits        93222    93230    +8     
+ Misses      17965    17959    -6     
+ Partials     3184     3182    -2     

see 15 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 26, 2023
@XuanYang-cn
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit fd979a7 into milvus-io:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants