Add predicates for TxnKV operations #27365
Conversation
sre-ci-robot
added
kind/enhancement
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia ut workflow job failed, comment |
| func (kv *MemoryKV) MultiSaveAndRemove(saves map[string]string, removals []string) error { | ||
| func (kv *MemoryKV) MultiSaveAndRemove(saves map[string]string, removals []string, preds ...predicates.Predicate) error { | ||
| if len(preds) > 0 { | ||
| return merr.WrapErrServiceUnavailable("predicates not supported") |
There was a problem hiding this comment.
maybe return a NotImplement error is better 🤔
There was a problem hiding this comment.
Mem KV does not support transaction feature
according to @yah01 this shall use ServiceUnavailable
Codecov Report
@@ Coverage Diff @@
## master #27365 +/- ##
==========================================
- Coverage 81.50% 81.50% -0.01%
==========================================
Files 801 803 +2
Lines 114371 114471 +100
==========================================
+ Hits 93222 93294 +72
- Misses 17965 17988 +23
- Partials 3184 3189 +5
|
congqixia
force-pushed
the
txn_kv_predicates
branch
2 times, most recently
from
4304d56 to
e298cb5
Compare
Signed-off-by: Congqi Xia <[email protected]>
congqixia
force-pushed
the
txn_kv_predicates
branch
from
e298cb5 to
3d81e8e
Compare
|
/lgtm |
See also #26758
DesignDoc #27183
/kind enhancement