Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the codec code of session #27360

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Optimize the codec code of session #27360

merged 1 commit into from
Oct 1, 2023

Conversation

longjiquan
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Sep 26, 2023
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 26, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #27360 (498a71f) into master (6ff4ffa) will decrease coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27360      +/-   ##
==========================================
- Coverage   81.45%   81.43%   -0.02%     
==========================================
  Files         804      804              
  Lines      114641   114589      -52     
==========================================
- Hits        93380    93315      -65     
- Misses      18076    18087      +11     
- Partials     3185     3187       +2
Files Coverage Δ
internal/util/sessionutil/session_util.go 80.02% <100.00%> (-0.97%) ⬇️

... and 12 files with indirect coverage changes

@longjiquan longjiquan force-pushed the opt-session branch 2 times, most recently from 5d55dd4 to f8b1374 Compare September 27, 2023 01:53
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Sep 28, 2023

/approve

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Sep 28, 2023
@czs007
Copy link
Collaborator

czs007 commented Oct 1, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0f14d18 into milvus-io:master Oct 1, 2023
7 checks passed
@longjiquan longjiquan deleted the opt-session branch October 7, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xige-16 xige-16 Awaiting requested review from xige-16

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@longjiquan @czs007 @sre-ci-robot