Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine querynode scheduler lifetime #26915

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

congqixia
Copy link
Contributor

This PR refines scheduler lifetime control:

  • Move private tri-state into lifetime package
  • Make scheduler block incoming "Add" task
  • Make scheduler Stop wait until all previously accepted task done

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Sep 7, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Sep 7, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia congqixia force-pushed the refine_querynode_scheduler branch from 3dc9d49 to 7206711 Compare September 7, 2023 09:46
@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia congqixia force-pushed the refine_querynode_scheduler branch from 7206711 to 72a8316 Compare September 7, 2023 10:08
@chyezh
Copy link
Contributor

chyezh commented Sep 8, 2023

/lgtm

@congqixia congqixia force-pushed the refine_querynode_scheduler branch from 72a8316 to 3a2e7f3 Compare September 26, 2023 10:19
@sre-ci-robot sre-ci-robot removed the lgtm label Sep 26, 2023
@congqixia congqixia force-pushed the refine_querynode_scheduler branch 3 times, most recently from 9526de6 to 987a6ee Compare September 27, 2023 09:50
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #26915 (0c1767a) into master (a8ce1b6) will decrease coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26915      +/-   ##
==========================================
- Coverage   81.45%   81.43%   -0.02%     
==========================================
  Files         803      804       +1     
  Lines      114586   114614      +28     
==========================================
+ Hits        93335    93341       +6     
- Misses      18069    18086      +17     
- Partials     3182     3187       +5     
Files Coverage Δ
internal/querynodev2/delegator/delegator.go 92.02% <100.00%> (-0.08%) ⬇️
internal/querynodev2/server.go 65.12% <100.00%> (+0.30%) ⬆️
internal/querynodev2/tasks/tasks.go 57.89% <ø> (ø)
pkg/util/lifetime/state.go 100.00% <100.00%> (ø)
...nal/querynodev2/tasks/concurrent_safe_scheduler.go 89.50% <78.68%> (-0.89%) ⬇️

... and 10 files with indirect coverage changes

This PR refines scheduler lifetime control:
- Move private tri-state into lifetime package
- Make scheduler block incoming "Add" task
- Make scheduler Stop wait until all previously accepted task done

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the refine_querynode_scheduler branch from 987a6ee to 0c1767a Compare September 27, 2023 11:39
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 27, 2023
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 258e1cc into milvus-io:master Sep 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants