-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine querynode scheduler lifetime #26915
Refine querynode scheduler lifetime #26915
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia E2e jenkins job failed, comment |
3dc9d49
to
7206711
Compare
@congqixia E2e jenkins job failed, comment |
7206711
to
72a8316
Compare
/lgtm |
72a8316
to
3a2e7f3
Compare
9526de6
to
987a6ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #26915 +/- ##
==========================================
- Coverage 81.45% 81.43% -0.02%
==========================================
Files 803 804 +1
Lines 114586 114614 +28
==========================================
+ Hits 93335 93341 +6
- Misses 18069 18086 +17
- Partials 3182 3187 +5
|
This PR refines scheduler lifetime control: - Move private tri-state into lifetime package - Make scheduler block incoming "Add" task - Make scheduler Stop wait until all previously accepted task done Signed-off-by: Congqi Xia <[email protected]>
987a6ee
to
0c1767a
Compare
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
/lgtm |
This PR refines scheduler lifetime control:
/kind improvement