Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: refine array view to optimize memory usage(#38736) #38808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: refine array view to optimize memory usage(#38736) #38808

wants to merge 1 commit into from
+183 −141

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Dec 27, 2024 •
edited
Loading

related: #38736

700m data, array_length=10
non-mmap_offsets_uint64: 1.9G
mmap_offsets_uint64: 1.1G
mmap_offsets_uint32: 980MB

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 30f7f6c to 48a53db Compare December 27, 2024 12:27
@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 48a53db to 22404ce Compare December 27, 2024 12:28
@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (18a3bc7) to head (1843325).
Report is 27 commits behind head on master.

❗ Current head 1843325 differs from pull request most recent head f5c49d7

Please upload reports for the commit f5c49d7 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38808       +/-   ##
===========================================
+ Coverage   69.45%   82.95%   +13.49%     
===========================================
  Files         294     1091      +797     
  Lines       26429   169640   +143211     
===========================================
+ Hits        18357   140717   +122360     
- Misses       8072    23330    +15258     
- Partials        0     5593     +5593
Components Coverage Δ
Client 79.12% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.10% <ø> (∅)

see 1385 files with indirect coverage changes

@MrPresent-Han
Copy link
Contributor Author

rerun ut

1 similar comment
@MrPresent-Han
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Dec 30, 2024
@sunby
Copy link
Contributor

sunby commented Dec 30, 2024

/lgtm

xiaofan-luan
xiaofan-luan reviewed Dec 30, 2024
View reviewed changes
internal/core/src/common/Array.h Outdated
@@ -438,19 +438,42 @@ class Array {
int size_ = 0;
std::vector<uint64_t> offsets_{};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. why not still keep offset ? Didn't see a strong reason to do so.
  2. why not change offset to unint32?

@MrPresent-Han
Copy link
Contributor Author

/hold

@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed lgtm size/M Denotes a PR that changes 30-99 lines. labels Dec 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. ci-passed labels Dec 31, 2024
@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from e9f48cb to e9a67eb Compare December 31, 2024 06:00
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from e9a67eb to 76efe5b Compare December 31, 2024 11:26
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Dec 31, 2024
@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 76efe5b to 089bf62 Compare December 31, 2024 11:28
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 089bf62 to 2d9236b Compare December 31, 2024 14:38
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 2d9236b to 381a776 Compare January 1, 2025 11:05
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 381a776 to 1843325 Compare January 1, 2025 15:17
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-mem-master branch from 1843325 to f5c49d7 Compare January 2, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@sunby sunby

Labels
area/compilation dco-passed DCO check passed. do-not-merge/hold kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrPresent-Han @sre-ci-robot @sunby @xiaofan-luan