Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: update expr version to support method parameter type conversion #38780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Dec 26, 2024

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Dec 26, 2024
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 26, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimFG
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (5395ec1) to head (3d6f469).
Report is 19 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38780       +/-   ##
===========================================
+ Coverage   69.33%   81.09%   +11.75%     
===========================================
  Files         292     1383     +1091     
  Lines       26187   195632   +169445     
===========================================
+ Hits        18158   158642   +140484     
- Misses       8029    31392    +23363     
- Partials        0     5598     +5598     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.43% <ø> (+0.09%) ⬆️
Go 83.08% <ø> (∅)

see 1114 files with indirect coverage changes

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

rerun cpp-unit-test

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

/run-cpu-e2e

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

rerun go-sdk

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

/run-cpu-e2e

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 27, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 27, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants