Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add mem size for index file and fallback to multiply with serialized size #38716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 24, 2024

issue: #38715

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Dec 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 24, 2024
internal/datacoord/index_meta.go Outdated Show resolved Hide resolved
internal/metastore/model/segment_index.go Outdated Show resolved Hide resolved
@chyezh chyezh force-pushed the enhance_mem_index_file_multiply_factor branch from 51bbb80 to 95b0b65 Compare December 24, 2024 12:11
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Dec 24, 2024
@chyezh chyezh force-pushed the enhance_mem_index_file_multiply_factor branch from 95b0b65 to 6ed14c8 Compare December 24, 2024 12:47
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (5304707) to head (6ed14c8).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38716   +/-   ##
=======================================
  Coverage   69.33%   69.33%           
=======================================
  Files         292      292           
  Lines       26187    26187           
=======================================
  Hits        18158    18158           
  Misses       8029     8029           
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.33% <ø> (ø)
Go ∅ <ø> (∅)

@tedxu
Copy link
Contributor

tedxu commented Dec 24, 2024

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants