Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealed segment get empty index params when brute force search for bm25 #38707

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 24, 2024

relate: #38236

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 24, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 24, 2024
Copy link
Contributor

mergify bot commented Dec 24, 2024

@aoiasd

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (636e107) to head (f5df5af).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 1 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38707      +/-   ##
==========================================
- Coverage   81.03%   81.02%   -0.01%     
==========================================
  Files        1380     1380              
  Lines      195154   195154              
==========================================
- Hits       158145   158131      -14     
- Misses      31438    31444       +6     
- Partials     5571     5579       +8     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <0.00%> (ø)
Go 83.00% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.92% <0.00%> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 84.42% <0.00%> (ø)

... and 25 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 24, 2024
@aoiasd aoiasd changed the title Fix sealed segment get empty index params when brute force search for bm25 fix: sealed segment get empty index params when brute force search for bm25 Dec 25, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug ci-passed and removed ci-passed do-not-merge/invalid-pr-format labels Dec 25, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit bc15ad2 into milvus-io:master Dec 25, 2024
18 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants