Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add cases for async milvus client #38699

Merged
merged 1 commit into from
Dec 25, 2024
Merged

test: add cases for async milvus client #38699

merged 1 commit into from
Dec 25, 2024

Conversation

ThreadDao
Copy link
Contributor

issue: #38697

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/test sig/testing labels Dec 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/test labels Dec 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 24, 2024

@ThreadDao go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 24, 2024
wangting0128
wangting0128 approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@wangting0128 wangting0128 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wangting0128
Copy link
Contributor

/lgtm

@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThreadDao, wangting0128, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ea339c1 into milvus-io:master Dec 25, 2024
5 checks passed
@yanliang567 yanliang567 mentioned this pull request Dec 25, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Dec 25, 2024
@ThreadDao
test: add cases for async milvus client (#38691)
604fb75 
issue: #38697
pr: #38699

Signed-off-by: ThreadDao <[email protected]>
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this pull request Dec 26, 2024
@ThreadDao @NicoYuan1986
test: add cases for async milvus client (milvus-io#38699)
7e735ca 
issue: milvus-io#38697

Signed-off-by: ThreadDao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangting0128 wangting0128 wangting0128 approved these changes

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@wangting0128 wangting0128

@yanliang567 yanliang567

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/test lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThreadDao @wangting0128 @yanliang567 @sre-ci-robot