-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add db name in replica #38672
base: master
Are you sure you want to change the base?
Conversation
7e087c8
to
4914c38
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38672 +/- ##
===========================================
+ Coverage 69.33% 81.11% +11.77%
===========================================
Files 292 1383 +1091
Lines 26187 195667 +169480
===========================================
+ Hits 18158 158718 +140560
- Misses 8029 31366 +23337
- Partials 0 5583 +5583
|
return &metricsinfo.Replica{ | ||
ID: r.GetID(), | ||
CollectionID: r.GetCollectionID(), | ||
DBName: dbName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to be dbID
4914c38
to
e9aa797
Compare
@jaime0815 go-sdk check failed, comment |
@jaime0815 E2e jenkins job failed, comment |
e9aa797
to
78678cd
Compare
@jaime0815 E2e jenkins job failed, comment |
@jaime0815 go-sdk check failed, comment |
78678cd
to
87d2e00
Compare
@jaime0815 cpp-unit-test check failed, comment |
Signed-off-by: jaime <[email protected]>
87d2e00
to
12a7c44
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jaime0815 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jaime0815 go-sdk check failed, comment |
issue: #36621