Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add db name in replica #38672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaime0815
Copy link
Contributor

issue: #36621

@sre-ci-robot sre-ci-robot added area/internal-api size/M Denotes a PR that changes 30-99 lines. labels Dec 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 23, 2024
@jaime0815 jaime0815 changed the title enhance: add db id in replica enhance: add db name in replica Dec 23, 2024
@jaime0815 jaime0815 force-pushed the add-db-id-in-replica branch from 7e087c8 to 4914c38 Compare December 23, 2024 13:13
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 71.01449% with 20 lines in your changes missing coverage. Please review.

Project coverage is 81.11%. Comparing base (5395ec1) to head (12a7c44).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/job/job_load.go 33.33% 6 Missing and 2 partials ⚠️
internal/datacoord/compaction_task_mix.go 69.23% 3 Missing and 1 partial ⚠️
internal/querycoordv2/meta/collection_manager.go 50.00% 3 Missing and 1 partial ⚠️
internal/querycoordv2/meta/replica_manager.go 66.66% 1 Missing and 2 partials ⚠️
internal/querycoordv2/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38672       +/-   ##
===========================================
+ Coverage   69.33%   81.11%   +11.77%     
===========================================
  Files         292     1383     +1091     
  Lines       26187   195667   +169480     
===========================================
+ Hits        18158   158718   +140560     
- Misses       8029    31366    +23337     
- Partials        0     5583     +5583     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.43% <ø> (+0.09%) ⬆️
Go 83.11% <71.01%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/compaction_task_clustering.go 79.24% <100.00%> (ø)
internal/datacoord/compaction_task_l0.go 92.91% <100.00%> (ø)
internal/datacoord/compaction_task_meta.go 75.63% <100.00%> (ø)
internal/datacoord/index_meta.go 95.32% <100.00%> (ø)
internal/metastore/model/segment_index.go 95.45% <100.00%> (ø)
internal/querycoordv2/utils/meta.go 71.22% <ø> (ø)
pkg/util/metricsinfo/metrics_info.go 100.00% <ø> (ø)
internal/querycoordv2/server.go 79.16% <0.00%> (ø)
internal/querycoordv2/meta/replica_manager.go 81.47% <66.66%> (ø)
internal/datacoord/compaction_task_mix.go 66.66% <69.23%> (ø)
... and 2 more

... and 1102 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 23, 2024
return &metricsinfo.Replica{
ID: r.GetID(),
CollectionID: r.GetCollectionID(),
DBName: dbName,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to be dbID

@jaime0815 jaime0815 force-pushed the add-db-id-in-replica branch from 4914c38 to e9aa797 Compare December 25, 2024 06:24
@mergify mergify bot removed the ci-passed label Dec 25, 2024
Copy link
Contributor

mergify bot commented Dec 25, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 25, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the add-db-id-in-replica branch from e9aa797 to 78678cd Compare December 25, 2024 06:49
Copy link
Contributor

mergify bot commented Dec 25, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 25, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815 jaime0815 force-pushed the add-db-id-in-replica branch from 78678cd to 87d2e00 Compare December 25, 2024 08:44
Copy link
Contributor

mergify bot commented Dec 25, 2024

@jaime0815 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@jaime0815 jaime0815 force-pushed the add-db-id-in-replica branch from 87d2e00 to 12a7c44 Compare December 26, 2024 09:21
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants