Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: eliminate compile warnings (part2) #38535

Merged

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Dec 17, 2024

See #38435

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/compilation labels Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 17, 2024
@tedxu tedxu force-pushed the enhance/eliminate_compile_warnings branch from 6c3d4b8 to 73ea362 Compare December 17, 2024 11:55
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 95.89041% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (29e620f) to head (73ea362).
Report is 55 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/common/Types.h 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38535   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files        1378     1378           
  Lines      194172   194170    -2     
=======================================
+ Hits       157207   157210    +3     
+ Misses      31410    31401    -9     
- Partials     5555     5559    +4     
Components Coverage Δ
Client 74.52% <ø> (ø)
Core 69.32% <95.89%> (-0.02%) ⬇️
Go 83.01% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/bitset/bitset.h 99.41% <100.00%> (-0.01%) ⬇️
internal/core/src/bitset/detail/element_wise.h 99.16% <ø> (ø)
internal/core/src/common/Array.h 92.99% <100.00%> (-0.03%) ⬇️
internal/core/src/common/Chunk.h 64.28% <100.00%> (ø)
internal/core/src/common/ChunkWriter.h 56.16% <100.00%> (ø)
internal/core/src/common/FieldData.h 100.00% <100.00%> (ø)
internal/core/src/common/FieldMeta.h 94.82% <100.00%> (+0.09%) ⬆️
internal/core/src/common/Span.h 100.00% <100.00%> (ø)
internal/core/src/exec/expression/EvalCtx.h 100.00% <100.00%> (ø)
internal/core/src/mmap/ChunkedColumn.h 52.71% <100.00%> (ø)
... and 11 more

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 17, 2024
@sunby
Copy link
Contributor

sunby commented Dec 18, 2024

/lgtm

@congqixia congqixia added this to the 2.5.1 milestone Dec 18, 2024
@congqixia
Copy link
Contributor

/hold
wait for 2.5.0 release

@congqixia
Copy link
Contributor

/unhold
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit acc8fb7 into milvus-io:master Dec 25, 2024
20 checks passed
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants