fix UT build break

Signed-off-by: Ted Xu <[email protected]>
milvus-io · Dec 17, 2024 · 73ea362 · 73ea362
1 parent 988eb63
commit 73ea362
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/internal/core/CMakeLists.txt b/internal/core/CMakeLists.txt
@@ -153,7 +153,6 @@ if ( APPLE )
             "-Wno-gnu-zero-variadic-macro-arguments"
             "-Wno-variadic-macros"
             "-Wno-reorder-ctor"
-            "-Wno-google-readability"
             "-DBOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED=1"
             )
 endif ()

diff --git a/internal/core/src/mmap/ChunkedColumn.h b/internal/core/src/mmap/ChunkedColumn.h
@@ -60,7 +60,6 @@ class ChunkedColumnBase : public ColumnBase {
     }
 
     virtual ~ChunkedColumnBase() = default;
-    ;
 
     void
     AppendBatch(const FieldDataPtr data) override {

diff --git a/internal/core/unittest/test_chunk_cache.cpp b/internal/core/unittest/test_chunk_cache.cpp
@@ -150,7 +150,7 @@ TEST_P(ChunkCacheTest, Read) {
             dense_file_name, descriptor, dense_field_meta, mmap_enabled);
         Assert(dense_column->DataByteSize() == dim * N * 4);
     }
-    auto actual_dense = (const float*)(dense_column->Data());
+    auto actual_dense = (const float*)(dense_column->Data(0));
     for (auto i = 0; i < N * dim; i++) {
         AssertInfo(dense_data[i] == actual_dense[i],
                    fmt::format(
@@ -168,7 +168,7 @@ TEST_P(ChunkCacheTest, Read) {
     }
     auto expected_sparse_size = 0;
     auto actual_sparse =
-        (const knowhere::sparse::SparseRow<float>*)(sparse_column->Data());
+        (const knowhere::sparse::SparseRow<float>*)(sparse_column->Data(0));
     for (auto i = 0; i < N; i++) {
         const auto& actual_sparse_row = actual_sparse[i];
         const auto& expect_sparse_row = sparse_data[i];
@@ -215,7 +215,7 @@ TEST_P(ChunkCacheTest, TestMultithreads) {
             Assert(dense_column->DataByteSize() == dim * N * 4);
         }
 
-        auto actual_dense = (const float*)dense_column->Data();
+        auto actual_dense = (const float*)dense_column->Data(0);
         for (auto i = 0; i < N * dim; i++) {
             AssertInfo(
                 dense_data[i] == actual_dense[i],
@@ -232,7 +232,7 @@ TEST_P(ChunkCacheTest, TestMultithreads) {
                 sparse_file_name, descriptor, sparse_field_meta, mmap_enabled);
         }
         auto actual_sparse =
-            (const knowhere::sparse::SparseRow<float>*)sparse_column->Data();
+            (const knowhere::sparse::SparseRow<float>*)sparse_column->Data(0);
         for (auto i = 0; i < N; i++) {
             const auto& actual_sparse_row = actual_sparse[i];
             const auto& expect_sparse_row = sparse_data[i];
-Original file line number
+Diff line change
@@ Expand Up / @@ -60,7 +60,6 @@ class ChunkedColumnBase : public ColumnBase { @@
         }
         virtual ~ChunkedColumnBase() = default;
-        ;
         void
         AppendBatch(const FieldDataPtr data) override {
@@ Expand Down @@