Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Eliminate compile warnings #38435

Open
1 task done
tedxu opened this issue Dec 13, 2024 · 0 comments
Open
1 task done

[Enhancement]: Eliminate compile warnings #38435

tedxu opened this issue Dec 13, 2024 · 0 comments
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@tedxu
Copy link
Contributor

tedxu commented Dec 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

The build process generated many C++ compile warnings, they should be handled correctly. To name a few:

  1. unnecessary copies in loops
  2. use move instead of copy if applicable
  3. declare with override on overriding functions

Why is this needed?

No response

Anything else?

No response
@tedxu tedxu added the kind/enhancement Issues or changes related to enhancement label Dec 13, 2024
@tedxu tedxu mentioned this issue Dec 13, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 16, 2024
@tedxu
enhance: eliminate compile warnings (#38420)
4919ccf 
See: #38435

---------

Signed-off-by: Ted Xu <[email protected]>
@tedxu tedxu mentioned this issue Dec 17, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 25, 2024
@tedxu
enhance: eliminate compile warnings (part2) (#38535)
acc8fb7 
See #38435

---------

Signed-off-by: Ted Xu <[email protected]>
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this issue Dec 26, 2024
@tedxu @NicoYuan1986
enhance: eliminate compile warnings (part2) (milvus-io#38535)
cc056e5 
See milvus-io#38435

---------

Signed-off-by: Ted Xu <[email protected]>
@tedxu tedxu mentioned this issue Dec 26, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jan 7, 2025
@tedxu
fix: build break under debug mode (#38790)
3dc9515 
See #38435

Signed-off-by: Ted Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tedxu