Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sync task still running after DataNode has stopped #38377

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: sync task still running after DataNode has stopped #38377

merged 1 commit into from
Dec 17, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #38319

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.58333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.80%. Comparing base (01fa2f8) to head (dbadbe4).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/flushcommon/writebuffer/write_buffer.go 33.33% 4 Missing and 2 partials ⚠️
internal/datanode/importv2/task_import.go 33.33% 3 Missing and 1 partial ⚠️
internal/datanode/importv2/task_l0_import.go 33.33% 3 Missing and 1 partial ⚠️
internal/datanode/data_node.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38377      +/-   ##
==========================================
+ Coverage   80.92%   82.80%   +1.88%     
==========================================
  Files        1377     1085     -292     
  Lines      193866   167771   -26095     
==========================================
- Hits       156887   138926   -17961     
+ Misses      31442    23311    -8131     
+ Partials     5537     5534       -3
Components Coverage Δ
Client 74.58% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.03% <64.58%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/flushcommon/syncmgr/sync_manager.go 90.27% <100.00%> (+1.04%) ⬆️
pkg/util/conc/pool.go 91.42% <100.00%> (+0.51%) ⬆️
pkg/util/paramtable/component_param.go 98.39% <100.00%> (+<0.01%) ⬆️
internal/datanode/data_node.go 75.58% <40.00%> (-0.71%) ⬇️
internal/datanode/importv2/task_import.go 76.74% <33.33%> (-1.83%) ⬇️
internal/datanode/importv2/task_l0_import.go 71.14% <33.33%> (-1.97%) ⬇️
internal/flushcommon/writebuffer/write_buffer.go 73.17% <33.33%> (-0.24%) ⬇️

... and 322 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop branch from d509123 to 63e11f7 Compare December 11, 2024 12:03
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop branch from 63e11f7 to f283e50 Compare December 11, 2024 13:07
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop branch from f283e50 to 25565dc Compare December 13, 2024 06:22
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815
Copy link
Contributor Author

rerun go-sdk

@jaime0815 jaime0815 mentioned this pull request Dec 13, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815
Copy link
Contributor Author

rerun go-sdk

@jaime0815 jaime0815 added this to the 2.5.0 milestone Dec 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@jaime0815 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop branch 3 times, most recently from 085a142 to cc689f7 Compare December 16, 2024 06:25
@mergify mergify bot added the ci-passed label Dec 16, 2024
@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop branch from cc689f7 to 69fe00b Compare December 16, 2024 09:37
@mergify mergify bot added ci-passed and removed ci-passed labels Dec 16, 2024
@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop branch from 69fe00b to 74a8587 Compare December 17, 2024 03:46
@mergify mergify bot removed the ci-passed label Dec 17, 2024
@jaime0815 jaime0815 force-pushed the fix-sync-task-run-after-dn-stop branch from 74a8587 to dbadbe4 Compare December 17, 2024 04:18
@mergify mergify bot added the ci-passed label Dec 17, 2024
congqixia
congqixia approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 29e620f into milvus-io:master Dec 17, 2024
19 of 20 checks passed
@jaime0815 jaime0815 deleted the fix-sync-task-run-after-dn-stop branch December 17, 2024 11:18
sre-ci-robot pushed a commit that referenced this pull request Dec 18, 2024
@jaime0815
fix: sync task still running after DataNode has stopped (#38441)
ee7dffc 
issue: #38319
pr: #38377

---------

Signed-off-by: jaime <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jaime0815 @sre-ci-robot @congqixia