Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Reduce mutex contention in datacoord meta #38230

Open
wants to merge 5 commits into
base: 2.4
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

  1. Using secondary index to avoid retrieving all segments at GetSegmentsChanPart.
  2. Perform batch SetAllocations to reduce the number of times the meta lock is acquired.

issue: #37630

pr: #38219

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 5, 2024
@mergify mergify bot added the ci-passed label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.45%. Comparing base (6f573f6) to head (7ee272c).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/meta.go 33.33% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38230      +/-   ##
==========================================
+ Coverage   72.15%   79.45%   +7.30%     
==========================================
  Files        1077     1077              
  Lines      169342   169347       +5     
==========================================
+ Hits       122185   134555   +12370     
+ Misses      42685    30313   -12372     
- Partials     4472     4479       +7     
Files with missing lines Coverage Δ
internal/datacoord/compaction_policy_clustering.go 75.24% <100.00%> (-0.12%) ⬇️
internal/datacoord/compaction_policy_single.go 60.60% <100.00%> (-0.40%) ⬇️
internal/datacoord/compaction_trigger.go 84.04% <100.00%> (-1.06%) ⬇️
internal/datacoord/meta.go 87.83% <33.33%> (-0.41%) ⬇️

... and 252 files with indirect coverage changes

Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot added ci-passed and removed ci-passed labels Dec 13, 2024
@mergify mergify bot removed the ci-passed label Dec 17, 2024
@bigsheeper
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Dec 17, 2024
@yanliang567 yanliang567 added this to the 2.4.18 milestone Dec 18, 2024
@czs007 czs007 removed this from the 2.4.18 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants