Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix grant/revoke v2 meta and unclear error messages #38110

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: fix grant/revoke v2 meta and unclear error messages #38110

merged 1 commit into from
Dec 2, 2024

Conversation

shaoting-huang
Copy link
Contributor

@shaoting-huang shaoting-huang commented Nov 29, 2024 •
edited
Loading

related issue: #37031

fixed issues:
#37974: better error messages for grant v2 interface
#37903: fix meta built-in privilege group object name
#37843: better error messages for custom privilege group interface
#38002: fix built-in privilege group meta to pass proxy interceptor check
#38008: fix revoke v2 to support revoking v1 granted privileges

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. labels Nov 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (bec5499) to head (2fac18c).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 92.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38110       +/-   ##
===========================================
+ Coverage   68.87%   81.08%   +12.21%     
===========================================
  Files         289     1369     +1080     
  Lines       25484   190978   +165494     
===========================================
+ Hits        17551   154863   +137312     
- Misses       7933    30634    +22701     
- Partials        0     5481     +5481
Components Coverage Δ
Client 73.67% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.22% <95.91%> (∅)
Files with missing lines Coverage Δ
internal/proxy/impl.go 84.84% <100.00%> (ø)
internal/proxy/util.go 89.93% <100.00%> (ø)
internal/rootcoord/meta_table.go 82.75% <100.00%> (ø)
pkg/util/constant.go 98.36% <100.00%> (ø)
pkg/util/merr/errors.go 92.18% <ø> (ø)
pkg/util/merr/utils.go 84.11% <100.00%> (ø)
internal/rootcoord/root_coord.go 89.53% <92.00%> (ø)

... and 1073 files with indirect coverage changes

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor

/lgtm

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot removed the lgtm label Nov 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@shaoting-huang
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@shaoting-huang
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 2, 2024
@weiliu1031
Copy link
Contributor

/lgtm

congqixia
congqixia approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 23dc313 into milvus-io:master Dec 2, 2024
20 checks passed
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 2, 2024
@shaoting-huang
fix grant/revoke v2 meta and unclear error messages [milvus-io#38110]
334b039 
Signed-off-by: shaoting-huang <[email protected]>
@shaoting-huang shaoting-huang mentioned this pull request Dec 2, 2024
Merged
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 2, 2024
@shaoting-huang
fix grant/revoke v2 meta and unclear error messages [milvus-io#38110] […
2924c99 
…milvus-io#38130]

Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 3, 2024
@shaoting-huang
fix grant/revoke v2 meta and unclear error messages [milvus-io#38110] […
0ae3016 
…milvus-io#38130]

Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 3, 2024
@shaoting-huang
fix grant/revoke v2 meta and unclear error messages [milvus-io#38110] […
77eeeac 
…milvus-io#38130]

Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 3, 2024
@shaoting-huang
fix grant/revoke v2 meta and unclear error messages [milvus-io#38110] […
64c4b91 
…milvus-io#38130]

Signed-off-by: shaoting-huang <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Dec 3, 2024
@shaoting-huang
fix: [2.4] fix grant/revoke v2 meta and unclear error messages (#38146)
66f2dac 
cherry-pick from #38110,
#38130
related issue: #37031

Signed-off-by: shaoting-huang <[email protected]>
@shaoting-huang shaoting-huang mentioned this pull request Dec 10, 2024
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@cydrain cydrain Awaiting requested review from cydrain

@czs007 czs007 Awaiting requested review from czs007

Assignees

@weiliu1031 weiliu1031

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaoting-huang @weiliu1031 @sre-ci-robot @congqixia